Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] - resolve sdist filepath issue #1938

Merged
merged 6 commits into from
May 2, 2024
Merged

[CI] - resolve sdist filepath issue #1938

merged 6 commits into from
May 2, 2024

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented May 2, 2024

Motivation and Context

For some reason the previous package paths (e.g. habitat-lab/dist/habitat-lab*.tar.gz) are now being written with underscore instead of hyphen (e.g. habitat-lab/dist/habitat_lab*.tar.gz). Not sure why this changed, but it was breaking CI verification.

How Has This Been Tested

CI

Types of changes

  • [Bug Fix] (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@aclegg3 aclegg3 requested review from rpartsey and 0mdc May 2, 2024 00:53
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 2, 2024
jimmytyyang
jimmytyyang approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@jimmytyyang jimmytyyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aclegg3 aclegg3 merged commit e504b07 into main May 2, 2024
4 checks passed
@aclegg3 aclegg3 deleted the alex-05_01-investigate-sdist-issue branch May 2, 2024 15:32
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jun 26, 2024
@aclegg3 @dannymcy
[CI] - resolve sdist filepath issue (facebookresearch#1938)
4aa73da 
* use underscores to match the files found
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@aclegg3
[CI] - resolve sdist filepath issue (facebookresearch#1938)
367c0fd 
* use underscores to match the files found
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@aclegg3 @dannymcy
[CI] - resolve sdist filepath issue (facebookresearch#1938)
4d59b06 
* use underscores to match the files found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmytyyang jimmytyyang jimmytyyang approved these changes

@rpartsey rpartsey Awaiting requested review from rpartsey

@0mdc 0mdc Awaiting requested review from 0mdc

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aclegg3 @jimmytyyang @facebook-github-bot