HITL - Add object state manipulation utility. #2042
Conversation
facebook-github-bot
added
the
CLA Signed
0mdc
requested review from
aclegg3,
MatthewChang,
eundersander and
zephirefaith
| True: OraclePowerOnInPlaceSkill, | ||
| False: OraclePowerOffInPlaceSkill, | ||
| }, | ||
| } |
There was a problem hiding this comment.
Would you happen to know whether we already have this information? It would be great to have a single source of truth and avoid drift here.
There was a problem hiding this comment.
I think you would reverse engineer the ObjectStateMachine instance by checking each active ObjectStateSpec for it's name:
Could be a helper function to do this in that class if it would be useful.
There was a problem hiding this comment.
Sounds like what we want. That may require some habitat_llm changes for skill auto-discovery.
I'll refactor this in a later pass.
| self, state_name: str, target_value: bool | ||
| ) -> Optional[OracleObjectStateInPlaceSkill]: | ||
| """ | ||
| Return a boolean action that allows for changing 'state_name' to 'target_value'. |
There was a problem hiding this comment.
Actions are not boolean, right?
There was a problem hiding this comment.
Ah you mean BooleanAction type. Got it. Reword the comment?
| actions.append( | ||
| BooleanAction( | ||
| state_spec=spec, | ||
| current_value=state.value, | ||
| target_value=target_value, | ||
| available=action_available, | ||
| enabled=action_enabled, | ||
| error=error, | ||
| ) |
There was a problem hiding this comment.
So you cache the actions available in the world for all objects and then pass these to the UI to populate with based on user's clicks?
Motivation and Context
This changeset introduces an utility to manipulate object states.
How Has This Been Tested
Tested with
habitat-llm.Types of changes
Checklist