HITL - Add selection panel and object state manipulation UI. #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
0mdc
commented
Aug 31, 2024
| if primary_region is not None: | ||
| primary_region_name = primary_region.category.name() | ||
|
|
||
| # Get the contextual information. |
There was a problem hiding this comment.
This section will be refactored in a later pass.
This will unify constraints across the application and clean up the UI code.
@aclegg3 : I'll wait until your constraint changes are applied before doing this.
0mdc
commented
Aug 31, 2024
| @@ -391,6 +399,16 @@ def _on_close(self, e: UI.CloseEventData): | |||
| } | |||
| ) | |||
|
|
|||
| def _on_state_change(self, e: UI.StateChangeEventData): | |||
There was a problem hiding this comment.
@zephirefaith You can use this callback to signal the agent that a state was changed.
| # Only humans can change object states. | ||
| can_change_object_states = isinstance( | ||
| self.gui_agent_controller, GuiHumanoidController | ||
| ) |
There was a problem hiding this comment.
@zephirefaith : I intend to move this into a rearrange_v2-level config, along with head sensor definition and feature flags.
aclegg3
approved these changes
Sep 4, 2024
| contextual_info = "Release to place." | ||
| contextual_color = color_ui_valid | ||
| else: | ||
| contextual_info = "Cannot place object here." |
There was a problem hiding this comment.
Yeah, this will be an injection point for more specific place constraint messages
0mdc
force-pushed
the
0mdc/hitl_selection_panel
branch
from
252d3eb to
89f622f
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This changeset adds a selection panel and object state manipulation controls.
The object state change event is recorded to HITL output.
The selection panel shows:
Builds on top of the following recent changes:
Held object contextual information:
selection_ui-2024-08-31_18.03.30.mp4
Object state manipulation:
selection_ui-2024-08-31_17.46.50.mp4
How Has This Been Tested
Tested on multiplayer HITL server with Unity clients.
Types of changes
Checklist