HITL - Change object state check function signature. #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
zephirefaith
reviewed
Sep 5, 2024
There was a problem hiding this comment.
Do we already have the UI knobs locally which show the available object-states and the ability to click on them?
There was a problem hiding this comment.
zephirefaith
approved these changes
Sep 5, 2024
Comment on lines
+163
to
+165
| if result.success: | ||
| self.set_object_state(object_handle, state_name, state_value) | ||
| return (success, error_message) | ||
| return ObjectStateChangeResult(result.success, result.error_message) |
There was a problem hiding this comment.
If result is not a success, is the error communicated anywhere to the user?
There was a problem hiding this comment.
No, in this case, it's just failing silently.
The UI calls can_execute_action every frame to check whether the user can execute the action. The message is passed here to be reactive to user's actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This changes the object state check function signature.
A result struct is used instead of a tuple.
How Has This Been Tested
Tested locally.
Types of changes
Checklist