Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HITL - Add KRM to HITL. #2043

Merged
merged 2 commits into from
Aug 28, 2024
Merged

HITL - Add KRM to HITL. #2043

merged 2 commits into from
Aug 28, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Aug 27, 2024 •
edited
Loading

Motivation and Context

This changeset integrates the Kinematic Relationship Manager to HITL.

krm-2024-08-28_15.54.47.mp4

How Has This Been Tested

Tested on local and remote applications.

Types of changes

  • [Development]

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 27, 2024
@0mdc 0mdc requested a review from aclegg3 August 27, 2024 01:06
aclegg3
aclegg3 approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me locally 👍

@aclegg3 aclegg3 marked this pull request as ready for review August 28, 2024 18:55
@0mdc
Copy link
Contributor Author

0mdc commented Aug 28, 2024

Thanks for taking a look at this one @aclegg3 !

@0mdc 0mdc merged commit 5de35b3 into main Aug 28, 2024
3 of 4 checks passed
@0mdc 0mdc deleted the 0mdc/hitl_krm branch August 28, 2024 19:57
@aclegg3 aclegg3 mentioned this pull request Aug 29, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0mdc @aclegg3 @facebook-github-bot