Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix][hitl] - don't update krm when placing on floors #2049

Merged
merged 1 commit into from
Aug 29, 2024
Merged

[bugfix][hitl] - don't update krm when placing on floors #2049

merged 1 commit into from
Aug 29, 2024

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Aug 29, 2024

Motivation and Context

patches a bug in #2043 when placing on floors and refactors sim_utilities import which pre-commit was complaining about

How Has This Been Tested

CI and local

Types of changes

  • [Bug Fix] (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@aclegg3 aclegg3 requested a review from 0mdc August 29, 2024 00:04
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 29, 2024
@aclegg3 aclegg3 changed the title [bugfix] - don't update krm when placing on floors [bugfix][hitl] - don't update krm when placing on floors Aug 29, 2024
0mdc
0mdc approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sneaky! Thanks you!

@0mdc 0mdc merged commit 7ffa25b into main Aug 29, 2024
4 checks passed
@0mdc 0mdc deleted the alex-08_28-krm_hitl_bugfix branch August 29, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0mdc 0mdc 0mdc approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aclegg3 @0mdc @facebook-github-bot