Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pointer to ROS-X-Habitat #743

Merged
merged 5 commits into from
Oct 10, 2021
Merged

Conversation

ericchen321
Copy link
Contributor

Motivation and Context

Added pointer to ROS-X-Habitat, a framework that bridges Habitat with ROS. Upon having a discussion with our research group, Dhruv and Manolis invited us to create a PR to refer to this work.

How Has This Been Tested

N/A (only changes to README.md)

Types of changes

  • Doc change

Checklist

  • [x ] My code follows the code style of this project.
  • [x ] My change requires a change to the documentation.
  • [x ] I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • [x ] I have completed my CLA (see CONTRIBUTING)
  • [x ] I have added tests to cover my changes.
  • [x ] All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 4, 2021
Copy link
Contributor

@erikwijmans erikwijmans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @mathfac @Skylion007 are you happy with adding this?

@Skylion007
Copy link
Contributor

Only qualms here is that we want to make it clear that the repo isn't officially supported by the Habitat-Lab team (yet). Otherwise, we may get ROS-X issues posted here etc.

@ericchen321
Copy link
Contributor Author

Only qualms here is that we want to make it clear that the repo isn't officially supported by the Habitat-Lab team (yet). Otherwise, we may get ROS-X issues posted here etc.

Hi @Skylion007, thanks for pointing it out! I've added a paragraph explaining ROS-X-Habitat is not officially supported by Habitat team.

Copy link
Contributor

@mathfac mathfac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work.

@mathfac mathfac merged commit 786a5ee into facebookresearch:master Oct 10, 2021
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
Added pointer to ROS-X-Habitat, a framework that bridges Habitat with ROS. Upon having a discussion with our research group, Dhruv and Manolis invited us to create a PR to refer to this work.
HHYHRHY pushed a commit to SgtVincent/EMOS that referenced this pull request Aug 31, 2024
Added pointer to ROS-X-Habitat, a framework that bridges Habitat with ROS. Upon having a discussion with our research group, Dhruv and Manolis invited us to create a PR to refer to this work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants