Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeoIP Mapping Does Not Support Multi-site Instance #393

Closed
jcdennen opened this issue Jul 17, 2020 · 0 comments · Fixed by #531
Closed

GeoIP Mapping Does Not Support Multi-site Instance #393

jcdennen opened this issue Jul 17, 2020 · 0 comments · Fixed by #531

Comments

@jcdennen
Copy link
Contributor

jcdennen commented Jul 17, 2020 •
edited
Loading

More details below - I'm mostly wondering if this is by design or if the team is looking to support this at some point

The current configuration

  • The current configuration setup allows admin users to specify which store view they wish to direct users to for a particular country code
  • In a single site installation of Magento this works as expected

The problem

  • In a multi-site installation, the configuration will only allow admin users to direct users to one store view (under one website) per country code

An example

  • www.example1.com and www.example2.com are both served by the same Magento instance
  • We want to do the following:
    • direct users visiting example1 from DE to example1's "German" store view (i.e. store code: example1_german)
    • direct users visiting example2 from DE to example2's "German" store view (i.e. store code: example2_german)
  • This is not possible

Another example

  • www.example1.com and www.example2.com are both served by the same Magento instance
  • We want to do the following:
    • direct users visiting example1 from DE to example1's "German" store view (i.e. store code: example1_german)
    • do not redirect users visiting example2 to any store view - AKA disable GeoIP redirection for the example2 website
  • This is not possible

Additional Details

  1. Platform: Magento Cloud
  2. PHP 7.2
  3. MariaDB 10.0.32
  4. Magento v2.3.5-p1 (latest)
  5. Fastly v1.2.141 (latest)
MartinPeverelli added a commit to interactiv4/fastly-magento2 that referenced this issue Nov 25, 2020
@MartinPeverelli
[M095M01A-43] [MAGENTO 2] Issue fastly#393
e858e36 
- Use current website to filter through available CountryCode mappings for valid Geo localizaed store view
dpotkoc added a commit to favicode/fastly-magento2 that referenced this issue May 3, 2022
@dpotkoc
Fix fastly#393
32e7183
dpotkoc added a commit to favicode/fastly-magento2 that referenced this issue May 3, 2022
@dpotkoc
Fix fastly#393
bbe967b
@dpotkoc dpotkoc mentioned this issue May 3, 2022
Merged
dpotkoc added a commit to favicode/fastly-magento2 that referenced this issue Jun 3, 2022
@dpotkoc
fix fastly#393
b73fce8
dpotkoc added a commit to favicode/fastly-magento2 that referenced this issue Jun 3, 2022
@dpotkoc
fix fastly#393
5665b77
dpotkoc added a commit to favicode/fastly-magento2 that referenced this issue Jun 3, 2022
@dpotkoc
fix fastly#393
66d4510
dpotkoc added a commit to favicode/fastly-magento2 that referenced this issue Jun 3, 2022
@dpotkoc
fix fastly#393
26d886b
@dpotkoc dpotkoc mentioned this issue Jun 3, 2022
Merged
vvuksan added a commit that referenced this issue Jun 3, 2022
@vvuksan
Merge pull request #537 from favicode/fix/improvement-393
388d684 
Fix/improvement #393
MickaelDatadome pushed a commit to DataDome/fastly-magento2 that referenced this issue Oct 5, 2023
@dpotkoc @MickaelDatadome
Fix fastly#393
6546e87
MickaelDatadome pushed a commit to DataDome/fastly-magento2 that referenced this issue Oct 5, 2023
@dpotkoc @MickaelDatadome
Fix fastly#393
3a61c4f
MickaelDatadome pushed a commit to DataDome/fastly-magento2 that referenced this issue Oct 5, 2023
@dpotkoc @MickaelDatadome
fix fastly#393
36e4c7a
MickaelDatadome pushed a commit to DataDome/fastly-magento2 that referenced this issue Oct 5, 2023
@dpotkoc @MickaelDatadome
fix fastly#393
8501d96
MickaelDatadome pushed a commit to DataDome/fastly-magento2 that referenced this issue Oct 5, 2023
@dpotkoc @MickaelDatadome
fix fastly#393
f0d3594
MickaelDatadome pushed a commit to DataDome/fastly-magento2 that referenced this issue Oct 5, 2023
@dpotkoc @MickaelDatadome
fix fastly#393
4183aec
MickaelDatadome added a commit to DataDome/fastly-magento2 that referenced this issue Oct 5, 2023
@MickaelDatadome
Datadome fastly 2.19.1 (#3)
d0a8d85 
Co-authored-by: Shohei Maeda <irt_m.jrsyo@ntworkers.com>
Co-authored-by: Domagoj Potkoc <domagoj@favicode.net>
Co-authored-by: kirgiv4oja <lukas.scharmitzer@gmail.com>
Co-authored-by: Vladimir Vuksan <vlemp@vuksan.com>
Co-authored-by: Pawel Siejba <60777305+pawel-siejba@users.noreply.github.com>
Co-authored-by: Andrew Kett <andrew.kett@overdose.digital>
Co-authored-by: Peter Dohogne <pdohogne@magento.com>
Co-authored-by: Lex <lex.koomen@kega.nl>
Co-authored-by: Dan Wallis <mrdanwallis@gmail.com>
Co-authored-by: Sean <sean@wahoofitness.com>
Co-authored-by: Domagoj Potkoc <dpotkoc@gmail.com>
Co-authored-by: Jack Scotson <jackscotson@gmail.com>
Co-authored-by: Bohdan Korablov <korablov@adobe.com>
Co-authored-by: github-actions <smaeda-ks smaeda-ks@users.noreply.github.com>
Co-authored-by: Alejandro Marroni <alejandrom@onetree.com>
Co-authored-by: github-actions <vvuksan vvuksan@users.noreply.github.com>
Co-authored-by: Vladimir Vuksan <vvuksan@users.noreply.github.com>
Co-authored-by: Joao Oliveira Pereira <jfopereira@gmail.com>
Co-authored-by: Borna Butkovic <borna@favicode.net>
Co-authored-by: Frangolacci Sebastien <67907942+Prunecreation@users.noreply.github.com>
Co-authored-by: Borzas Laszlo <lborzas@eshopworld.com>
Co-authored-by: mizdebski-netacea <marek.izdebski@netacea.com>
Co-authored-by: Pawel Siejba <pawel.siejba@vaimo.com>
Co-authored-by: ivanviduka <viduka.ivan@gmail.com>
Co-authored-by: Lauredg <laure.degrieve@datadome.co>
Co-authored-by: Lauredg <93923163+Lauredg@users.noreply.github.com>
Fix unset req.http.graphql
fix typo (fastly#464)
fix Fastly const value ti int value fastly#466
fix plugin annotation fastly#466
fix fastly#466
fixing old value in core_config_data fastly#466
fix type check in Image (fastly#472)
fix config save - image optimization fastly#476
Fix ambiguous behavior in Blocking toggle (fastly#479)
Fix type check (fastly#483)
Fix bugs in upadte backend dialog (fastly#487)
Fix for: GetUpdateFlag call flushes all configuration fastly#499
Fix for fastly#504
fix for fastly#520
fixing duplicate line reported under issue#518
Fix fastly#393
fix fastly#393
Fix javascript fastly#544
fix fastly#551
fix getImageOptimization - Deprecated Functionality: explode(): Passing null to parameter #2
fix for fastly#549 as submitted by customer
@MickaelDatadome MickaelDatadome mentioned this issue Oct 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@jcdennen