Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetUpdateFlag call flushes all configuration #499

Closed
eristyl opened this issue Jan 18, 2022 · 3 comments · Fixed by #501
Closed

GetUpdateFlag call flushes all configuration #499

eristyl opened this issue Jan 18, 2022 · 3 comments · Fixed by #501

Comments

@eristyl
Copy link

eristyl commented Jan 18, 2022

Hello,

When the ajax call checkUpdateFlag is made, it triggers $this->typeList->cleanType('config'); which ends in a flush of all Redis config cache keys.

Which means that displaying the Fastly configuration is Magento admin flushes all config cache.
There are the "redis-cli monitor | grep DEL" logs related to this ajax call:

1642063406.667723 [0 127.0.0.1:xxxx] "DEL" "zc:k:6s5d4fs54_MEDIA_GALLERY_PATTERNS_CACHEID" "zc:k:6s5d4fs54_GLOBAL__CONFIG_CACHE" "zc:k:6s5d4fs54_PROVIDER_ACL_RESOURCES_CACHE" "zc:k:6s5d4fs54_CONSTRAINT_CONFIG_CACHE" "zc:k:6s5d4fs54_COMMUNICATION_CONFIG_CACHE" "zc:k:6s5d4fs54_INDICES_CONFIG_OPTIMIZER" "zc:k:6s5d4fs54_APP_35C0BF370AE35F8C482DC31B8A81FC2F" "zc:k:6s5d4fs54_CONNECTION_CONFIG_CACHE" "zc:k:6s5d4fs54_SYSTEM_SCOPES" "zc:k:6s5d4fs54_SYSTEM_WEBSITES_BASE" "zc:k:6s5d4fs54_ELASTICSUITE_REQUEST_DECLARATION" "zc:k:6s5d4fs54_GLOBAL__EVENT_CONFIG_CACHE" "zc:k:6s5d4fs54_ADMINHTML__RESOURCESCACHE" "zc:k:6s5d4fs54_ANALYSIS_CONFIG" "zc:k:6s5d4fs54_AUTHORIZATION_RULE_CACHED_DATA" "zc:k:6s5d4fs54_PAYMENT_CONFIG" "zc:k:6s5d4fs54_FRONTEND__CSP_WHITELIST_CONFIG" "zc:k:6s5d4fs54_SYSTEM_WEBSITES_ADMIN" "zc:k:6s5d4fs54_INDICES_CONFIG" "zc:k:6s5d4fs54_APP_108B5EBA5ECACA9F6E9F88D4CD04D6E0" "zc:k:6s5d4fs54_CRON_GROUPS_CONFIG_CACHE" "zc:k:6s5d4fs54_SYSTEM_STORES_0" "zc:k:6s5d4fs54_CRONTAB__RESOURCESCACHE" "zc:k:6s5d4fs54_BACKEND_MENU_OBJECT" "zc:k:6s5d4fs54_SMILE_ELASTICSUITE_INITIAL_CONFIG" "zc:k:6s5d4fs54_MESSAGE_QUEUE_CONSUMER_CONFIG_CACHE" "zc:k:6s5d4fs54_RESOLVED_STORES_D1BEFA03C79CA0B84ECC488DEA96BC68" "zc:k:6s5d4fs54_GLOBAL__CSP_WHITELIST_CONFIG" "zc:k:6s5d4fs54_ADDRESS_FORMAT" "zc:k:6s5d4fs54_SYSTEM_STORES_1" "zc:k:6s5d4fs54_SYSTEM_DEFAULT" "zc:k:6s5d4fs54_MAGENTO_ANALYTICS_REPORTXML_CACHEID" "zc:k:6s5d4fs54_MAGE_VERSION" "zc:k:6s5d4fs54_ADMINHTML__EVENT_CONFIG_CACHE" "zc:k:6s5d4fs54_EAV_ATTRIBUTES" "zc:k:6s5d4fs54_FRONTEND__EVENT_CONFIG_CACHE" "zc:k:6s5d4fs54_SYSTEM_WEBSITES_0" "zc:k:6s5d4fs54_SMILE_RECONFIGURE_CONFIG" "zc:k:6s5d4fs54_INDICES_CONFIG_TRACKING_LOG_EVENT" "zc:k:6s5d4fs54_LOGGING_CONFIG" "zc:k:6s5d4fs54_EMAIL_TEMPLATES" "zc:k:6s5d4fs54_RESOLVED_STORES_D7A094A061F9E5121D10DBCA79ABB6E0" "zc:k:6s5d4fs54_SYSTEM_STORES_BOBRICO" "zc:k:6s5d4fs54_PAGE_TYPES_CONFIG" "zc:k:6s5d4fs54_UI_COMPONENT_CONFIGURATION_DATA_NOTIFICATION_AREA" "zc:k:6s5d4fs54_MVIEW_CONFIG" "zc:k:6s5d4fs54_ADMINHTML__BACKEND_SYSTEM_CONFIGURATION_STRUCTURE" "zc:k:6s5d4fs54_INDICES_CONFIG_TRACKING_LOG_SESSION" "zc:k:6s5d4fs54_AUTHORIZATION_ROLE_CACHED_DATA" "zc:k:6s5d4fs54_INDICES_CONFIG_CATALOG_CATEGORY" "zc:k:6s5d4fs54_MAGENTO_ANALYTICS_CACHEID" "zc:k:6s5d4fs54_SYSTEM_STORES_2" "zc:k:6s5d4fs54_FRONTEND__ROUTESCONFIG" "zc:k:6s5d4fs54_SYSTEM_STORES_ADMIN" "zc:k:6s5d4fs54_SMILE_PUBSUB" "zc:k:6s5d4fs54_INDEXER_CONFIG" "zc:k:6s5d4fs54_EXTENSION_ATTRIBUTES_CONFIG" "zc:k:6s5d4fs54_SECTIONS_INVALIDATION_CONFIG" "zc:k:6s5d4fs54_INITIAL_CONFIG" "zc:k:6s5d4fs54_PRODUCT_TYPES_CONFIG" "zc:k:6s5d4fs54_DB_IS_UP_TO_DATE" "zc:k:6s5d4fs54_PRODUCT_OPTIONS_CONFIG" "zc:k:6s5d4fs54_MEDIA_CONTENT_PATTERNS_CACHEID" "zc:k:6s5d4fs54_INDICES_CONFIG_CATALOG_PRODUCT" "zc:k:6s5d4fs54_APP_14D56884DCC568789CA1733D23CB4BF4" "zc:k:6s5d4fs54_CRONTAB_CONFIG_CACHE" "zc:k:6s5d4fs54_SYSTEM_WEBSITES_1" "zc:k:6s5d4fs54_MESSAGE_QUEUE_CONFIG_CACHE" "zc:k:6s5d4fs54_FRONTEND__RESOURCESCACHE" "zc:k:6s5d4fs54_CRONTAB__EVENT_CONFIG_CACHE" "zc:k:6s5d4fs54_SYSTEM" "zc:k:6s5d4fs54_APP_CE79F7EF764E9F981C8549B9DBEC468F" "zc:k:6s5d4fs54_ADMINHTML__ROUTESCONFIG" "zc:k:6s5d4fs54_UI_COMPONENT_CONFIGURATION_DEFINITION_DATA" "zc:k:6s5d4fs54_APP_4169C5DEEEB8F84FEFBFAC574BE2769B" "zc:k:6s5d4fs54_UI_COMPONENT_TEMPLATES" "zc:k:6s5d4fs54_ADMINHTML__CSP_WHITELIST_CONFIG" "zc:k:6s5d4fs54_ADMINHTML__CONFIG_CACHE" "zc:k:6s5d4fs54_GLOBAL__RESOURCESCACHE"

@dpotkoc
Copy link
Contributor

dpotkoc commented Jan 19, 2022

@eristyl Please could you send to us exactly Magento version.

Thnx
Domagoj

@eristyl
Copy link
Author

eristyl commented Jan 19, 2022

Hello @dpotkoc,

I'm using: Magento ver. 2.4.2-p1

Regards

dpotkoc added a commit to favicode/fastly-magento2 that referenced this issue Jan 20, 2022
vvuksan added a commit that referenced this issue Jan 21, 2022
Fix for: GetUpdateFlag call flushes all configuration #499
@vvuksan
Copy link
Contributor

vvuksan commented Jan 21, 2022

Fixed in 1.2.178

MickaelDatadome pushed a commit to DataDome/fastly-magento2 that referenced this issue Oct 5, 2023
MickaelDatadome added a commit to DataDome/fastly-magento2 that referenced this issue Oct 5, 2023
Co-authored-by: Shohei Maeda <irt_m.jrsyo@ntworkers.com>
Co-authored-by: Domagoj Potkoc <domagoj@favicode.net>
Co-authored-by: kirgiv4oja <lukas.scharmitzer@gmail.com>
Co-authored-by: Vladimir Vuksan <vlemp@vuksan.com>
Co-authored-by: Pawel Siejba <60777305+pawel-siejba@users.noreply.github.com>
Co-authored-by: Andrew Kett <andrew.kett@overdose.digital>
Co-authored-by: Peter Dohogne <pdohogne@magento.com>
Co-authored-by: Lex <lex.koomen@kega.nl>
Co-authored-by: Dan Wallis <mrdanwallis@gmail.com>
Co-authored-by: Sean <sean@wahoofitness.com>
Co-authored-by: Domagoj Potkoc <dpotkoc@gmail.com>
Co-authored-by: Jack Scotson <jackscotson@gmail.com>
Co-authored-by: Bohdan Korablov <korablov@adobe.com>
Co-authored-by: github-actions <smaeda-ks smaeda-ks@users.noreply.github.com>
Co-authored-by: Alejandro Marroni <alejandrom@onetree.com>
Co-authored-by: github-actions <vvuksan vvuksan@users.noreply.github.com>
Co-authored-by: Vladimir Vuksan <vvuksan@users.noreply.github.com>
Co-authored-by: Joao Oliveira Pereira <jfopereira@gmail.com>
Co-authored-by: Borna Butkovic <borna@favicode.net>
Co-authored-by: Frangolacci Sebastien <67907942+Prunecreation@users.noreply.github.com>
Co-authored-by: Borzas Laszlo <lborzas@eshopworld.com>
Co-authored-by: mizdebski-netacea <marek.izdebski@netacea.com>
Co-authored-by: Pawel Siejba <pawel.siejba@vaimo.com>
Co-authored-by: ivanviduka <viduka.ivan@gmail.com>
Co-authored-by: Lauredg <laure.degrieve@datadome.co>
Co-authored-by: Lauredg <93923163+Lauredg@users.noreply.github.com>
Fix unset req.http.graphql
fix typo (fastly#464)
fix Fastly const value ti int value fastly#466
fix plugin annotation fastly#466
fix fastly#466
fixing old value in core_config_data fastly#466
fix type check in Image (fastly#472)
fix config save - image optimization fastly#476
Fix ambiguous behavior in Blocking toggle (fastly#479)
Fix type check (fastly#483)
Fix bugs in upadte backend dialog (fastly#487)
Fix for: GetUpdateFlag call flushes all configuration fastly#499
Fix for fastly#504
fix for fastly#520
fixing duplicate line reported under issue#518
Fix fastly#393
fix fastly#393
Fix javascript fastly#544
fix fastly#551
fix getImageOptimization - Deprecated Functionality: explode(): Passing null to parameter #2
fix for fastly#549 as submitted by customer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants