Fix bugs in upadte backend dialog #487
Merged
+184
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MickaelDatadome
pushed a commit
to DataDome/fastly-magento2
that referenced
this pull request
Oct 5, 2023
* Use `filter_var` for domain validation * Don't convert empty string to null on PUT * Update shielding list * Update warning message * Fix field position * `generateDataCenterOptions` should run before `initValues` to avoid resetting `shield` value
MickaelDatadome
added a commit
to DataDome/fastly-magento2
that referenced
this pull request
Oct 5, 2023
Co-authored-by: Shohei Maeda <irt_m.jrsyo@ntworkers.com> Co-authored-by: Domagoj Potkoc <domagoj@favicode.net> Co-authored-by: kirgiv4oja <lukas.scharmitzer@gmail.com> Co-authored-by: Vladimir Vuksan <vlemp@vuksan.com> Co-authored-by: Pawel Siejba <60777305+pawel-siejba@users.noreply.github.com> Co-authored-by: Andrew Kett <andrew.kett@overdose.digital> Co-authored-by: Peter Dohogne <pdohogne@magento.com> Co-authored-by: Lex <lex.koomen@kega.nl> Co-authored-by: Dan Wallis <mrdanwallis@gmail.com> Co-authored-by: Sean <sean@wahoofitness.com> Co-authored-by: Domagoj Potkoc <dpotkoc@gmail.com> Co-authored-by: Jack Scotson <jackscotson@gmail.com> Co-authored-by: Bohdan Korablov <korablov@adobe.com> Co-authored-by: github-actions <smaeda-ks smaeda-ks@users.noreply.github.com> Co-authored-by: Alejandro Marroni <alejandrom@onetree.com> Co-authored-by: github-actions <vvuksan vvuksan@users.noreply.github.com> Co-authored-by: Vladimir Vuksan <vvuksan@users.noreply.github.com> Co-authored-by: Joao Oliveira Pereira <jfopereira@gmail.com> Co-authored-by: Borna Butkovic <borna@favicode.net> Co-authored-by: Frangolacci Sebastien <67907942+Prunecreation@users.noreply.github.com> Co-authored-by: Borzas Laszlo <lborzas@eshopworld.com> Co-authored-by: mizdebski-netacea <marek.izdebski@netacea.com> Co-authored-by: Pawel Siejba <pawel.siejba@vaimo.com> Co-authored-by: ivanviduka <viduka.ivan@gmail.com> Co-authored-by: Lauredg <laure.degrieve@datadome.co> Co-authored-by: Lauredg <93923163+Lauredg@users.noreply.github.com> Fix unset req.http.graphql fix typo (fastly#464) fix Fastly const value ti int value fastly#466 fix plugin annotation fastly#466 fix fastly#466 fixing old value in core_config_data fastly#466 fix type check in Image (fastly#472) fix config save - image optimization fastly#476 Fix ambiguous behavior in Blocking toggle (fastly#479) Fix type check (fastly#483) Fix bugs in upadte backend dialog (fastly#487) Fix for: GetUpdateFlag call flushes all configuration fastly#499 Fix for fastly#504 fix for fastly#520 fixing duplicate line reported under issue#518 Fix fastly#393 fix fastly#393 Fix javascript fastly#544 fix fastly#551 fix getImageOptimization - Deprecated Functionality: explode(): Passing null to parameter #2 fix for fastly#549 as submitted by customer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixes:
We must not convert empty string to
nullon PUT (update) requests. Because withhttp_build_query, params with null value do not present in the result string, and hence they won't get reset (application/x-www-form-urlencoded).Override hostfield position in the dialog window (currently, it's under theTIMEOUTSsection)generateDataCenterOptionsshould run beforeinitValuesto avoid resettingshieldvalue when editing the existing backends