Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obejectId query cmd update #360

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Conversation

Yuqing-cat
Copy link
Collaborator

If user is using Azure CLI Version <= 2.36, then the original objectId works.
However, the cloud shell always run the latest version. Thus, I just simply update command in each occurrence.

(Please check the issue link to find more backgrounds about Azure CLI upgrade)

Also, I'd like to raise a potential risk of doc maintenance: this command exists in 8 files and 5 of them are notebook / markdown guide. Will it be better to abstract the content into a single "How-to-provision-azure-resource" and link to it?

@Yuqing-cat Yuqing-cat added the bug Something isn't working label Jun 14, 2022
@Yuqing-cat Yuqing-cat self-assigned this Jun 14, 2022
@Yuqing-cat Yuqing-cat linked an issue Jun 14, 2022 that may be closed by this pull request
@Yuqing-cat Yuqing-cat added the documentation Improvements or additions to documentation label Jun 14, 2022
Copy link
Collaborator

@jainr jainr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this fix with objectId, I also made the fix for this in my ARM template PR but in only covers the template.

I am not sure if you reformatted but there seems a big delta in ARM template, was any other thing changed except objectId?

@xiaoyongzhu xiaoyongzhu merged commit ac204bb into feathr-ai:main Jun 14, 2022
@jainr
Copy link
Collaborator

jainr commented Jun 14, 2022

I also agree with consolidating this in a single place, please share your ideas.

bozhonghu pushed a commit that referenced this pull request Jun 15, 2022
* main:
  Fixing purview test issues and improve performance (#350)
  [feathr] Add product_recommendation advanced sample (#348)
  obejectId query cmd update (#360)
  add license, release, docs, python api ref badges with shields img (#357)
  quick fix the 404 not found in read me link (#355)
  Python SQL Registry (#311)
  enable JWT token param in frontend API calls (#337)
  Optimize environment variable behavior (#333)
  Adding better warning message to let user know that config file is missing and they need to set env parameters. (#347)
  Feature Monitoring (#330)
  Windoze/211 maven submission (#334)
  Windoze/211 maven submission (#334)
  Windoze/211 maven submission (#334)
  Fix Synapse quickstart link (#346)
  Show feature details when click feature in lineage graph (#339)
  Update pull_request_push_test.yml
  Update UI README for how to create overrides for local development (#335)
  Update databricks quick start experience (#217)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ObjectId query cmd doesn't work in latest az cli
3 participants