Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query styling #2345

Merged
merged 3 commits into from
Jun 30, 2023
Merged

query styling #2345

merged 3 commits into from
Jun 30, 2023

Conversation

xannem
Copy link
Contributor

@xannem xannem commented Jun 16, 2023

Summary

  • misc. query styling edits

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@changeset-bot
Copy link

changeset-bot bot commented Jun 16, 2023

🦋 Changeset detected

Latest commit: edea1b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@finos/legend-extension-dsl-service Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-art Patch
@finos/legend-lego Patch
@finos/legend-query-builder Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-query Patch
@finos/legend-application-studio Patch
@finos/legend-application Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-mastery Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-manual-tests Patch
@finos/legend-application-studio-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #2345 (edea1b0) into master (dc34a3f) will increase coverage by 0.24%.
The diff coverage is 8.33%.

@@            Coverage Diff             @@
##           master    #2345      +/-   ##
==========================================
+ Coverage   40.68%   40.92%   +0.24%     
==========================================
  Files        1546     1560      +14     
  Lines       73666    73732      +66     
  Branches    17306    17326      +20     
==========================================
+ Hits        29968    30178     +210     
+ Misses      43576    43431     -145     
- Partials      122      123       +1     
Impacted Files Coverage Δ
...vice/src/components/query/ServiceRegisterModal.tsx 17.24% <0.00%> (+10.74%) ⬆️
...kages/legend-lego/src/code-editor/CodeDiffView.tsx 12.82% <0.00%> (-1.07%) ⬇️
.../src/components/data-access/DataAccessOverview.tsx 17.74% <0.00%> (-0.60%) ⬇️
...ges/legend-art/src/panel/PanelLoadingIndicator.tsx 33.33% <33.33%> (+3.33%) ⬆️

... and 56 files with indirect coverage changes

@xannem xannem marked this pull request as ready for review June 22, 2023 16:45
@xannem xannem requested a review from a team as a code owner June 22, 2023 16:45
@akphi akphi merged commit 7ad84dc into finos:master Jun 30, 2023
9 of 10 checks passed
@akphi akphi deleted the qs branch June 30, 2023 21:34
akphi added a commit to akphi/legend-studio that referenced this pull request Jul 1, 2023
akphi added a commit that referenced this pull request Jul 1, 2023
* bump dependencies

* cleanup post #2382

* cleanup post #2382 (part 2) - refactor to use useState()

* minor cleanup post #2393

* cleanup post #2345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants