Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor cleanup after #1704 #2393

Merged
merged 1 commit into from
Jun 30, 2023
Merged

minor cleanup after #1704 #2393

merged 1 commit into from
Jun 30, 2023

Conversation

gayathrir11
Copy link
Contributor

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@gayathrir11 gayathrir11 requested a review from a team as a code owner June 30, 2023 17:24
@changeset-bot
Copy link

changeset-bot bot commented Jun 30, 2023

🦋 Changeset detected

Latest commit: 35632a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@finos/legend-application-studio Patch
@finos/legend-query-builder Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-mastery Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-application-query Patch
@finos/legend-manual-tests Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-pure-ide-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #2393 (35632a5) into master (b2d51ef) will not change coverage.
The diff coverage is 30.76%.

@@           Coverage Diff           @@
##           master    #2393   +/-   ##
=======================================
  Coverage   40.92%   40.92%           
=======================================
  Files        1561     1561           
  Lines       73829    73829           
  Branches    17355    17355           
=======================================
  Hits        30216    30216           
  Misses      43489    43489           
  Partials      124      124           
Impacted Files Coverage Δ
.../components/editor/editor-group/FunctionEditor.tsx 12.65% <ø> (ø)
...or/editor-group/mapping-editor/MappingExplorer.tsx 66.66% <ø> (ø)
...nts/editor/editor-group/uml-editor/ClassEditor.tsx 50.34% <0.00%> (ø)
...or/editor-state/element-editor-state/ClassState.ts 48.75% <0.00%> (ø)
.../mapping/FlatDataInstanceSetImplementationState.ts 9.84% <0.00%> (ø)
...tate/mapping/PureInstanceSetImplementationState.ts 9.24% <0.00%> (ø)
...tional/RelationalInstanceSetImplementationState.ts 9.16% <0.00%> (ø)
...tor-state/mapping/testable/MappingTestableState.ts 14.05% <0.00%> (ø)
...editor-state/service/ServicePostValidationState.ts 10.16% <0.00%> (ø)
...-builder/src/components/QueryBuilderTextEditor.tsx 83.87% <ø> (ø)
... and 10 more

@akphi akphi merged commit 8d63367 into finos:master Jun 30, 2023
@akphi akphi deleted the todo branch June 30, 2023 17:53
akphi added a commit to akphi/legend-studio that referenced this pull request Jul 1, 2023
akphi added a commit that referenced this pull request Jul 1, 2023
* bump dependencies

* cleanup post #2382

* cleanup post #2382 (part 2) - refactor to use useState()

* minor cleanup post #2393

* cleanup post #2345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants