Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query filter ui edit #2382

Merged
merged 4 commits into from
Jun 30, 2023
Merged

query filter ui edit #2382

merged 4 commits into from
Jun 30, 2023

Conversation

xannem
Copy link
Contributor

@xannem xannem commented Jun 28, 2023

fixes #2380

Summary

  • don't show the rearranging indicator when DND projection column leaves the fetch window
  • edit DND projection column rearranging indicator so that when dragging the first or last column the indicator line is where its expected

Kapture 2023-06-29 at 14 43 19

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2023

🦋 Changeset detected

Latest commit: 0832d69

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@finos/legend-query-builder Patch
@finos/legend-application-query Patch
@finos/legend-application-studio Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-manual-tests Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-mastery Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-pure-ide-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@xannem xannem self-assigned this Jun 28, 2023
@xannem xannem marked this pull request as ready for review June 28, 2023 05:33
@xannem xannem requested a review from a team as a code owner June 28, 2023 05:33
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #2382 (0832d69) into master (dec6f9e) will increase coverage by 0.12%.
The diff coverage is 51.85%.

@@            Coverage Diff             @@
##           master    #2382      +/-   ##
==========================================
+ Coverage   40.79%   40.92%   +0.12%     
==========================================
  Files        1560     1561       +1     
  Lines       73695    73844     +149     
  Branches    17307    17364      +57     
==========================================
+ Hits        30064    30218     +154     
+ Misses      43508    43502       -6     
- Partials      123      124       +1     
Impacted Files Coverage Δ
...stores/fetch-structure/tds/QueryBuilderTDSState.ts 66.66% <25.00%> (-0.56%) ⬇️
...omponents/fetch-structure/QueryBuilderTDSPanel.tsx 63.09% <52.38%> (-1.08%) ⬇️
...ts/fetch-structure/QueryBuilderPostFilterPanel.tsx 11.92% <100.00%> (+0.31%) ⬆️
.../src/components/filter/QueryBuilderFilterPanel.tsx 58.20% <100.00%> (+0.16%) ⬆️

... and 40 files with indirect coverage changes

@xannem xannem added the Component: Query Builder Issues related to query builder core label Jun 29, 2023
@akphi akphi merged commit 1ad3cd0 into finos:master Jun 30, 2023
@akphi akphi deleted the filterq branch June 30, 2023 23:40
akphi added a commit to akphi/legend-studio that referenced this pull request Jul 1, 2023
akphi added a commit to akphi/legend-studio that referenced this pull request Jul 1, 2023
akphi added a commit that referenced this pull request Jul 1, 2023
* bump dependencies

* cleanup post #2382

* cleanup post #2382 (part 2) - refactor to use useState()

* minor cleanup post #2393

* cleanup post #2345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Builder Issues related to query builder core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Enhance rearranging columns experience in query properties fetch panel
2 participants