[DO NOT MERGE] Add GitHub to supported IDPs #710
Conversation
|
|
||
| <activity | ||
| android:name=".provider.GitHubLoginHolder" | ||
| android:label="" |
There was a problem hiding this comment.
This is the first main issue: adding singleInstance creates a new task which very bad. The UI looks weird and if the user goes to their recent apps list, the CCT instance shows up separate from the login app. I need this so that I can get an onNewIntent call without a new instance of the holder activity being created. Is there some other way to accomplish this? I've tried singleTop with no success.
|
|
||
| <category android:name="android.intent.category.DEFAULT"/> | ||
| <category android:name="android.intent.category.BROWSABLE"/> | ||
|
|
There was a problem hiding this comment.
This is the second major issue. I couldn't figure out how to listen for the Google handle: https://fir-ui-playground.firebaseapp.com/__/auth/handler. I need some way for GitHub to redirect directly to our app and it wasn't working with the Google handler so I had to make up my own scheme. @samtstern @amandle Do you guys know how to do this with the Googler handler or know someone at Google who does?
| } | ||
|
|
||
| private String getScopeList() { | ||
| return "user:email"; |
# Conflicts: # auth/src/main/java/com/firebase/ui/auth/util/signincontainer/SmartLockBase.java
Merge version-2.0.0-dev into master
Change-Id: I661d5f056c292b2679be1921e972366810cef2ee
Change-Id: Ibe0bfa105b5e316b992552727df0e6167c10cf56
Version 2.0.1
All examples of the `new Chat(...)` constructor being used in the code assume the message is the 3rd parameter passed to the constructor and not the 2nd.
typo : PROVDER -> PROVIDER
…eir account instead of the first one (#701)
# Conflicts: # auth/src/main/java/com/firebase/ui/auth/AuthUI.java # auth/src/main/java/com/firebase/ui/auth/ui/idp/AuthMethodPickerActivity.java # auth/src/main/java/com/firebase/ui/auth/util/signincontainer/IdpSignInContainer.java # auth/src/main/res/values/strings.xml # auth/src/test/java/com/firebase/ui/auth/ui/idp/AuthMethodPickerActivityTest.java
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
Going to close this PR until I can properly figure it out. |
6 participants
#346
@samtstern I'm really excited about this one!!! 😄 Figuring out how to add GitHub has literally been in the back of my mind for months now and I finally managed to do the oauth dance with Chrome Custom Tabs.
I'm putting this PR out so that people can hopefully help me out, but it's in no way ready. There are a few issues that I'll list in a PR review. Still, it's finally happening, FirebaseUI-Android will be a complete library! 😄 🚀 🎉
project_id