Swift Codable and Extension DocumentSnapshot #2636
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Prevent Messaging and IID singleton usage during tests. * Remove other uses of static Messaging instance. * Removed usages of messagingForTests. * Remove unused imports, unify testing code. * Use local import path instead of framework import.
* Reorder tests to match Android * Add missing NS_ASSUME_NONNULL_BEGIN * Add missing [self awaitExpectations] * Port can write very large batches from Android
* Remove FSTMutationQueue
This XCode target started failing on Travis for no clear reason. This isn't reproducible locally; remove the target to unblock development.
…8) (firebase#2334) * Log swiftformat version in non-interactive builds. * Use a mildly-terrible regex for version check to ensure at least 0.35.0 (travis has 0.35.8). * Include StorageViewController.swift change swiftformat 0.38 makes (but which seems to be compatible with 0.35)
Port flaky test fix from web. Port of firebase/firebase-js-sdk#1511
* Fix new Xcode 10.2 warning
This is to remove ambiguity from other `iam` acronyms.
* FIRInAppMessagingDisplayMessage and FIRInAppMessagingDisplayDelegate refactor + downstream changes * More downstream changes from FIRInAppMessagingDisplayDelegate, calling through to app-side delegate from default display executor * Add delegate property on FIRInAppMessaging * Display SDK changes to pass through in app message with callbacks * Headless SDK unit test refactoring * Display test app downstream changes * Pull in headless SDK in display app, no need to have this come in as a framework anymore * Run scripts/style.sh * Remove WIP test * Refactor FIRIAMDIsplayExecutor to take an InAppMessaging object for testing * Depend on FirebaseAnalyticsInterop in UI test app * File imports for FIRInAppMessaging files * Remove FirebaseInAppMessaging imports
…s refreshed. b/77662386 (firebase#2562)
* Port FSTLocalDocumentsView to C++. * Replace callers of FSTLocalDocumentsView * Remove FSTLocalDocumentsView
All the various table drivers that need to navigate back must use weak pointers to get there because the parent owns the children.
* Add nanopb::CheckedSize Fix implicit narrowing warnings and reduce pb_size_t copypasta. * Rename local::DocumentReference to DocumentKeyReference This cleans up a build-time warning about a duplicate file in the Copy Headers phase and cleans up a massive duplicate id warning during pod install.
* Replace FSTDocumentSet's guts with immutable::SortedSet. * Port FSTDocumentSet to C++ DocumentSet. * Replace implementation of FSTDocumentSet with C++ DocumentSet * Update all usages of FSTDocumentSet * Remove FSTDocumentSet * Add Objective-C++ guard * Use absl::c_equal instead of hand-rolling it. * Split SortedContainer out of SortedMapBase ... and use it * Fix NSNotFound -> npos * Remove = default constructors that aren't true. These are implicitly deleted because DocumentSet is a member and isn't default constructible. * Fix usage of FSTQuery.limit
* Add a lint check for ostream * Actaully #include <ostream> to undefined stream insertion operators at link time
|
@1amageek Thanks! Would you retarget the PR to the |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
|
@paulb777 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
Continue Firestore codable after squashing #838 and #2178
#2229
Testing
Add DocumentSnapshot test
API Changes
Add toObject to DocumentSnapshot.
It is based on android sdk.
https://github.com/firebase/firebase-android-sdk/blob/29fa815997572914b02226430a70409198795669/firebase-firestore-ktx/src/main/kotlin/com/google/firebase/firestore/ktx/Firestore.kt#L118