fix: clicking on CupertinoContextMenuAction doesn't close context menu

[ndonkoHenri]

Summary by Sourcery

Fix the issue where clicking on a CupertinoContextMenuAction does not close the context menu by adding a pop action. Improve the error message in CupertinoContextMenu for better clarity and remove an unnecessary debug print statement from PopupMenuButtonControl. Correct the return type of get_input_devices_async in audio_recorder.py to return a dictionary instead of a boolean.

Bug Fixes:

• Ensure that clicking on a CupertinoContextMenuAction closes the context menu by adding a call to Navigator.of(context).pop() in the onPressed callback.

Enhancements:

• Correct the error message in CupertinoContextMenu to improve clarity by fixing a grammatical error.

Chores:

• Remove a debug print statement from PopupMenuButtonControl to clean up the code.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request addresses an issue with the CupertinoContextMenuAction not closing the context menu when clicked. It also includes minor improvements to error messages, type annotations, and removes debug printing.

File-Level Changes

Change	Details	Files
Fix CupertinoContextMenuAction to close the context menu when clicked	Remove unnecessary DefaultTextStyle widget Add Navigator.of(context).pop() to close the menu on click Simplify child widget creation	packages/flet/lib/src/controls/cupertino_context_menu_action.dart
Improve error message in CupertinoContextMenu	Fix typo in error message for CupertinoContextMenu.actions	packages/flet/lib/src/controls/cupertino_context_menu.dart
Correct return type annotation in AudioRecorder	Change return type of get_input_devices_async from bool to dict	sdk/python/packages/flet-core/src/flet_core/audio_recorder.py
Remove debug print statement in PopupMenuButton	Delete debugPrint line for showing tooltip	packages/flet/lib/src/controls/popup_menu_button.dart

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

Hey @ndonkoHenri - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding a comment explaining the reason for calling Navigator.of(context).pop() in the CupertinoContextMenuAction's onPressed callback.
• Verify that removing the DefaultTextStyle wrapper in CupertinoContextMenuAction doesn't negatively impact text styling. If it's intentional, consider adding a comment explaining the change.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}