fix: ensure ElevatedButton Properties (bgcolor, color, elevation) are correctly updated

[InesaFitsner]

Description

The issue was that bgcolor, color and elevation were were not updated (only updated for the first time).

Fixes #4119

Test Code

import flet as ft


def main(page: ft.Page):

    test_button = ft.ElevatedButton(
        "Click to change color",
        icon="park_rounded",
        icon_color="green400",
        color=ft.colors.WHITE,
        bgcolor=ft.colors.RED,
        style=ft.ButtonStyle(text_style=ft.TextStyle(italic=True)),
    )

    def on_click(e):
        if test_button.text == "red":
            test_button.text = "blue"
            test_button.bgcolor = ft.colors.BLUE_800
            test_button.color = ft.colors.BLACK
            test_button.elevation = 10
        else:
            test_button.text = "red"
            test_button.bgcolor = ft.colors.RED_800
            test_button.color = ft.colors.WHITE
            test_button.elevation = 20
        page.update()

    def change_color(e):
        e.control.style = ft.ButtonStyle(
            bgcolor=ft.colors.YELLOW, color=ft.colors.BLACK, elevation=20
        )
        page.update()

    test_button.on_click = on_click

    style_button = ft.ElevatedButton(
        "Click to change style",
        icon="park_rounded",
        icon_color="green400",
        # bgcolor=ft.colors.RED,
        style=ft.ButtonStyle(
            bgcolor=ft.colors.GREEN, color=ft.colors.RED, elevation=10
        ),
        on_click=change_color,
    )

    page.add(test_button, style_button)


ft.app(main)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update. Need to add that bgcolor, color and elevation properties override bgcolor, color and elevation in button.style

Checklist:

• I signed the CLA.
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings

• New and existing tests pass locally with my changes
• I have made corresponding changes to the documentation (if applicable)

Screenshots (if applicable):

Additional details

Summary by Sourcery

Fix the update mechanism for bgcolor, color, and elevation properties in the ElevatedButton component to ensure they are correctly applied after the initial setting. Update documentation to reflect the behavior of these properties.

Bug Fixes:

• Fix the issue where bgcolor, color, and elevation properties were not updated after the initial setting in the ElevatedButton component.

Documentation:

• Update documentation to clarify that bgcolor, color, and elevation properties override the corresponding properties in button.style.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes a bug in the ElevatedButton class where the bgcolor, color, and elevation properties were not being properly updated after the initial setting. The changes ensure that these properties override the corresponding values in the button's style when explicitly set.

Updated class diagram for ElevatedButton

classDiagram
    class ElevatedButton {
        - __color
        - __bgcolor
        - __elevation
        - __style
        + before_update()
    }
    class ButtonStyle {
        + color
        + bgcolor
        + elevation
        + side
        + shape
        + padding
    }
    ElevatedButton --> ButtonStyle
    ElevatedButton : +before_update()

Loading

File-Level Changes

Change	Details	Files
Refactored the before_update method in the ElevatedButton class to properly handle color, bgcolor, and elevation updates	Removed conditional assignments that were preventing updates to color, bgcolor, and elevation Added explicit checks for non-None values of color, bgcolor, and elevation Directly assigned the new values to the style properties when they are set	sdk/python/packages/flet-core/src/flet_core/elevated_button.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @InesaFitsner - I've reviewed your changes - here's some feedback:

Overall Comments:

• Thank you for this fix. Please remember to update the documentation as mentioned in your checklist to reflect that bgcolor, color, and elevation properties override the corresponding properties in button.style.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue (code-quality): Extract code out into method (extract-method)

[ndonkoHenri]

Looks good to me.