fix: disabling filled buttons is not visually respected

[InesaFitsner]

Description

Background color and color for FilledTonalButton and FilledButton. Instead of hardcoding colors now different flutter buttons will be created.

Fixes #3941

Test Code

import flet as ft


def main(page: ft.Page):

    page.add(
        ft.FilledTonalButton(
            text="Disabled FilledTonalButton",
            on_click=lambda e: print("Disabled FilledTonalButton clicked!"),
            icon=ft.icons.SEARCH,
            disabled=True,
        ),
        ft.FilledTonalButton(
            text="FilledTonalButton",
            on_click=lambda e: print("FilledTonalButton clicked!"),
            icon=ft.icons.SEARCH,
            # disabled=True,
        ),
        ft.FilledTonalButton(
            text="Disabled FilledTonalButton no icon",
            on_click=lambda e: print("Disabled FilledTonalButton clicked!"),
            # icon=ft.icons.SEARCH,
            disabled=True,
        ),
        ft.FilledTonalButton(
            text="FilledTonalButton no icon",
            on_click=lambda e: print("FilledTonalButton clicked!"),
            # icon=ft.icons.SEARCH,
            # disabled=True,
        ),
        ft.FilledTonalButton(
            text="Disabled FilledTonalButton no icon + content",
            on_click=lambda e: print("Disabled FilledTonalButton clicked!"),
            content=ft.Checkbox(),
            # icon=ft.icons.SEARCH,
            disabled=True,
        ),
        ft.FilledTonalButton(
            text="FilledTonalButton no icon + content",
            on_click=lambda e: print("FilledTonalButton clicked!"),
            content=ft.Checkbox(),
            # icon=ft.icons.SEARCH,
            # disabled=True,
        ),
        ft.FilledButton(
            text="Disabled FilledButton",
            on_click=lambda e: print("Disabled ElevatedButton clicked!"),
            icon=ft.icons.SEARCH,
            disabled=True,
        ),
        ft.FilledButton(
            text="FilledButton",
            on_click=lambda e: print("FilledButton clicked!"),
            icon=ft.icons.SEARCH,
            # disabled=True,
        ),
        ft.FilledButton(
            text="Disabled FilledButton no icon",
            on_click=lambda e: print("Disabled ElevatedButton clicked!"),
            # icon=ft.icons.SEARCH,
            disabled=True,
        ),
        ft.FilledButton(
            text="FilledButton no icon",
            on_click=lambda e: print("FilledButton clicked!"),
            # icon=ft.icons.SEARCH,
            # disabled=True,
        ),
        ft.ElevatedButton(
            text="Disabled ElevatedButton",
            on_click=lambda e: print("Disabled ElevatedButton clicked!"),
            icon=ft.icons.SEARCH,
            disabled=True,
        ),
        ft.ElevatedButton(
            text="ElevatedButton",
            on_click=lambda e: print("ElevatedButton clicked!"),
            icon=ft.icons.SEARCH,
            # disabled=True,
        ),
        ft.ElevatedButton(
            text="Disabled RED ElevatedButton",
            on_click=lambda e: print("Disabled ElevatedButton clicked!"),
            bgcolor=ft.colors.RED,
            icon=ft.icons.SEARCH,
            disabled=True,
        ),
        ft.ElevatedButton(
            text="RED ElevatedButton",
            on_click=lambda e: print("ElevatedButton clicked!"),
            bgcolor=ft.colors.RED,
            icon=ft.icons.SEARCH,
            # disabled=True,
        ),
        ft.OutlinedButton(
            text="Disabled OutlinedButton",
            on_click=lambda e: print("Disabled OutlinedButton clicked!"),
            icon=ft.icons.SEARCH,
            disabled=True,
        ),
        ft.OutlinedButton(
            text="OutlinedButton",
            on_click=lambda e: print("OutlinedButton clicked!"),
            icon=ft.icons.SEARCH,
            # disabled=True,
        ),
    )


ft.app(target=main)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist:

• I signed the CLA.
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings

• New and existing tests pass locally with my changes
• I have made corresponding changes to the documentation (if applicable)

Screenshots (if applicable):

Additional details

Summary by Sourcery

Refactor button components to support dynamic color attributes, fixing hardcoded color issues and enhancing customization options for FilledTonalButton and FilledButton.

Bug Fixes:

• Fix the issue with hardcoded colors in FilledTonalButton and FilledButton by allowing dynamic color attributes.

Enhancements:

• Introduce attributes for color, background color, and elevation in FilledButton and FilledTonalButton to enhance customization.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request implements changes to the FilledTonalButton and FilledButton components in the Flet framework. It modifies the button creation logic to support different types of buttons (Elevated, Filled, and FilledTonal) based on new attributes. The changes also include updates to the Python SDK to reflect these new button types and their properties.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Refactored button creation logic in ElevatedButtonControl	Added new boolean attributes 'filled' and 'filledtonal' to determine button type Created separate variables for ElevatedButton, FilledButton, and FilledTonalButton Updated button creation logic to handle icon and non-icon versions of each button type Modified the return statement to use the appropriate button type based on attributes	packages/flet/lib/src/controls/elevated_button.dart
Updated FilledButton class in Python SDK	Added new optional parameters for color, bgcolor, and elevation Removed hardcoded values for color, bgcolor, and elevation Added a new attribute 'filled' to distinguish FilledButton	sdk/python/packages/flet-core/src/flet_core/filled_button.py
Updated FilledTonalButton class in Python SDK	Added new optional parameters for color, bgcolor, and elevation Removed hardcoded values for color, bgcolor, and elevation Added a new attribute 'filledtonal' to distinguish FilledTonalButton	sdk/python/packages/flet-core/src/flet_core/filled_tonal_button.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @InesaFitsner - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider refactoring the _ElevatedButtonControlState class to improve readability and maintainability. The class is becoming quite large and complex with the addition of new button types.
• Explore using a design pattern (e.g., factory or strategy) for handling different button types. This could make it easier to add new button types in the future without modifying existing code.
• While the manual testing is thorough, consider adding automated unit tests to ensure consistent verification of the new functionality.

Here's what I looked at during the review

• 🟡 General issues: 2 issues found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[ndonkoHenri]

Just from pushing a commit with the addition of _get_control_name in both filled buttons, for a better distinction.

[ndonkoHenri]

@sourcery-ai review

[sourcery-ai]

Hi @ndonkoHenri! 👋

Only authors and team members can run @sourcery-ai commands on public repos.