Remove "unnecessary" imports. #25736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
CI looks good. |
|
CI still looks good. |
In each library where an import is removed, the library uses some elements provided by the import, BUT there is another import which provides all of the same elements, and at least one more which the library uses. In this change, we remove the imports which can be simply removed in favor of the other already present imports. See dart-lang/sdk#44569 for more information.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 12, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 12, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 12, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 12, 2021
cbracken
pushed a commit
to flutter/flutter
that referenced
this pull request
May 13, 2021
* b629338 Roll Skia from c1b6b6c615a7 to d9a7c5953df3 (2 revisions) (flutter/engine#26089) * 5d67ad1 Get licenses check deps from gclient rather than pub (flutter/engine#26077) * b2104fa Roll Dart SDK from d59cb89f73fe to 934cc986926d (1 revision) (flutter/engine#26090) * b825396 Roll Fuchsia Linux SDK from 1PbnXEErn... to MoY7UVVro... (flutter/engine#26091) * 2b5b0b8 Roll Skia from d9a7c5953df3 to 827bb729a84d (2 revisions) (flutter/engine#26093) * e834ec3 Remove "unnecessary" imports. (flutter/engine#25736) * da5aaf8 Roll Skia from d9a7c5953df3 to 827bb729a84d (2 revisions) (flutter/engine#26096) * e13e345 Roll Skia from 827bb729a84d to 433d25c947e4 (3 revisions) (flutter/engine#26097) * 99021da Sped up the objc standard message codec (flutter/engine#25998) * d7229e9 Roll Skia from 433d25c947e4 to 0270bf5d10be (5 revisions) (flutter/engine#26100) * a339374 Move more parts to libs. Move bitmap/dom canvas to /html (flutter/engine#26072)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In each library where an import is removed, the library uses some elements
provided by the import, BUT there is another import which provides all of the
same elements, and at least one more which the library uses.
In this change, we remove the imports which can be simply removed in favor of
the other already present imports.
See dart-lang/sdk#44569 for more information.
List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#74381 is improved by this issue. Not fixed.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.