Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move more parts to libs. Move bitmap/dom canvas to /html #26072

Merged
merged 7 commits into from
May 12, 2021
Merged

Move more parts to libs. Move bitmap/dom canvas to /html #26072

merged 7 commits into from
May 12, 2021

Conversation

ferhatb
Copy link
Contributor

@ferhatb ferhatb commented May 11, 2021

  • Convert shader.dart to library.
  • Move dom/bitmap_canvas.dart to html.
  • Separate image shader to prepare for implementation in canvas commands.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the [engine presubmit flakes form] before re-triggering the failure.

@ferhatb ferhatb requested a review from yjbanov May 11, 2021 16:52
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label May 11, 2021
@google-cla google-cla bot added the cla: yes label May 11, 2021
yjbanov
yjbanov approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ferhatb
Copy link
Contributor Author

ferhatb commented May 12, 2021

merging on infra failure

@ferhatb ferhatb merged commit a339374 into flutter:master May 12, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
@engine-flutter-autoroll
a339374 Move more parts to libs. Move bitmap/dom canvas to /html (flu…
607a132 
…tter/engine#26072)
cbracken pushed a commit to flutter/flutter that referenced this pull request May 13, 2021
@engine-flutter-autoroll
Roll Engine from f3847fe to a339374 (11 revisions) (#82388)
66cb378 
* b629338 Roll Skia from c1b6b6c615a7 to d9a7c5953df3 (2 revisions) (flutter/engine#26089)

* 5d67ad1 Get licenses check deps from gclient rather than pub (flutter/engine#26077)

* b2104fa Roll Dart SDK from d59cb89f73fe to 934cc986926d (1 revision) (flutter/engine#26090)

* b825396 Roll Fuchsia Linux SDK from 1PbnXEErn... to MoY7UVVro... (flutter/engine#26091)

* 2b5b0b8 Roll Skia from d9a7c5953df3 to 827bb729a84d (2 revisions) (flutter/engine#26093)

* e834ec3 Remove "unnecessary" imports. (flutter/engine#25736)

* da5aaf8 Roll Skia from d9a7c5953df3 to 827bb729a84d (2 revisions) (flutter/engine#26096)

* e13e345 Roll Skia from 827bb729a84d to 433d25c947e4 (3 revisions) (flutter/engine#26097)

* 99021da Sped up the objc standard message codec (flutter/engine#25998)

* d7229e9 Roll Skia from 433d25c947e4 to 0270bf5d10be (5 revisions) (flutter/engine#26100)

* a339374 Move more parts to libs. Move bitmap/dom canvas to /html (flutter/engine#26072)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees
No one assigned
Labels
cla: yes platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferhatb @yjbanov