Get licenses check deps from gclient rather than pub #26077
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Adding to pub_get_offline.py tests that all dependencies are really already present in the tree, and not retrieved from the pub cache. |
| @@ -62,7 +62,6 @@ dart --version | |||
| # Runs in a subshell. | |||
| function collect_licenses() ( | |||
| cd "$SRC_DIR/flutter/tools/licenses" | |||
| pub get | |||
There was a problem hiding this comment.
The dependencies should already be in place by way of gclient sync, and I'd like to narrow down the places where we're using pub.
zanderso
added
the
waiting for tree to go green
* b629338 Roll Skia from c1b6b6c615a7 to d9a7c5953df3 (2 revisions) (flutter/engine#26089) * 5d67ad1 Get licenses check deps from gclient rather than pub (flutter/engine#26077) * b2104fa Roll Dart SDK from d59cb89f73fe to 934cc986926d (1 revision) (flutter/engine#26090) * b825396 Roll Fuchsia Linux SDK from 1PbnXEErn... to MoY7UVVro... (flutter/engine#26091) * 2b5b0b8 Roll Skia from d9a7c5953df3 to 827bb729a84d (2 revisions) (flutter/engine#26093) * e834ec3 Remove "unnecessary" imports. (flutter/engine#25736) * da5aaf8 Roll Skia from d9a7c5953df3 to 827bb729a84d (2 revisions) (flutter/engine#26096) * e13e345 Roll Skia from 827bb729a84d to 433d25c947e4 (3 revisions) (flutter/engine#26097) * 99021da Sped up the objc standard message codec (flutter/engine#25998) * d7229e9 Roll Skia from 433d25c947e4 to 0270bf5d10be (5 revisions) (flutter/engine#26100) * a339374 Move more parts to libs. Move bitmap/dom canvas to /html (flutter/engine#26072)
Instead of using pub to get the dependencies of the license check script, this PR explicitly points the script's pubspec.yaml file at the dependencies it needs it needs that are already populated in the source tree by
gclient sync. To accomplish this, it adds a checkout of thearchivepackage from github to the DEPS file.Related flutter/flutter#82134