allow null in compute for weak mode #63515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
framework
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
This was referenced Aug 13, 2020
13 tasks
christopherfujino
pushed a commit
to christopherfujino/flutter
that referenced
this pull request
Aug 27, 2020
christopherfujino
added a commit
that referenced
this pull request
Aug 27, 2020
* update engine hash * allow null in compute for weak mode (#63515) * [Material] Relanding fix to ensure time picker input mode lays out correctly in RTL (#64097) * pin customer-testing * [flutter_tool] Handle Windows line endings in packages_test.dart (#63806) * [flutter_tool] Fix some create_test.dart tests on Windows (#63796) Co-authored-by: Alexandre Ardhuin <alexandre.ardhuin@gmail.com> Co-authored-by: Rami <2364772+rami-a@users.noreply.github.com> Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
christopherfujino
pushed a commit
to christopherfujino/flutter
that referenced
this pull request
Sep 1, 2020
christopherfujino
added a commit
that referenced
this pull request
Sep 1, 2020
* Update engine hash to 1.20.3 * Re-enable image_list test with updated certificate(good for 3650 days). (#64519) * [Material] Relanding fix to ensure time picker input mode lays out correctly in RTL (#64097) * allow null in compute for weak mode (#63515) * [flutter_tools] fix recursive asset variant issue (#61129) * [flutter_tool] Handle Windows line endings in packages_test.dart (#63806) * [flutter_tool] Fix some create_test.dart tests on Windows (#63796) Co-authored-by: Alexander Aprelev <aam@google.com> Co-authored-by: Rami <2364772+rami-a@users.noreply.github.com> Co-authored-by: Alexandre Ardhuin <alexandre.ardhuin@gmail.com> Co-authored-by: Jonah Williams <jonahwilliams@google.com> Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
mohammedJ-Sadiq
added a commit
to mohammedJ-Sadiq/flutter
that referenced
this pull request
Jan 17, 2021
* Update engine hash to 1.20.3 * Re-enable image_list test with updated certificate(good for 3650 days). (flutter#64519) * [Material] Relanding fix to ensure time picker input mode lays out correctly in RTL (flutter#64097) * allow null in compute for weak mode (flutter#63515) * [flutter_tools] fix recursive asset variant issue (flutter#61129) * [flutter_tool] Handle Windows line endings in packages_test.dart (flutter#63806) * [flutter_tool] Fix some create_test.dart tests on Windows (flutter#63796) Co-authored-by: Alexander Aprelev <aam@google.com> Co-authored-by: Rami <2364772+rami-a@users.noreply.github.com> Co-authored-by: Alexandre Ardhuin <alexandre.ardhuin@gmail.com> Co-authored-by: Jonah Williams <jonahwilliams@google.com> Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In weak mode
null is Tis always false even with a nullable type as type parameter T.This PR fix
computethat have null result.Related Issues
Tests
I added the following tests:
None
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.