Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Material] Relanding fix to ensure time picker input mode lays out correctly in RTL #64097

Merged
merged 3 commits into from
Aug 19, 2020

Conversation

rami-a
Copy link
Contributor

@rami-a rami-a commented Aug 18, 2020

Description

This is re-landing #63599 and it ensures that the hours and minutes are laid out correctly for RTL for the time picker input mode.

In the previous PR, the ":" separator became vertically offset from the hours and minutes because of the addition of a nested Row widget that didn't specify the crossAxisAlignment appropriately. So it was reverted in #64094. This PR adds a fix for that.

Related Issues

Fixes #63427

Tests

I added the following tests:

  • a test to check the position of elements in various locales including an RTL one
  • a regression test to check the position of the separator compared to the hour/minute text fields

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

Sorry, something went wrong.

rami-a and others added 2 commits August 18, 2020 17:23

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@flutter-dashboard flutter-dashboard bot added a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Aug 18, 2020
@rami-a rami-a requested review from HansMuller and johnsonmh August 18, 2020 21:42
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@johnsonmh johnsonmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@perclasson perclasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rami-a rami-a merged commit 021cf56 into flutter:master Aug 19, 2020
@rami-a rami-a deleted the reland-time-picker-input-rtl branch August 19, 2020 13:30
smadey pushed a commit to smadey/flutter that referenced this pull request Aug 27, 2020
christopherfujino pushed a commit to christopherfujino/flutter that referenced this pull request Aug 27, 2020
christopherfujino added a commit that referenced this pull request Aug 27, 2020
* update engine hash
* allow null in compute for weak mode (#63515)
* [Material] Relanding fix to ensure time picker input mode lays out correctly in RTL (#64097)
* pin customer-testing
* [flutter_tool] Handle Windows line endings in packages_test.dart (#63806)
* [flutter_tool] Fix some create_test.dart tests on Windows (#63796)

Co-authored-by: Alexandre Ardhuin <alexandre.ardhuin@gmail.com>
Co-authored-by: Rami <2364772+rami-a@users.noreply.github.com>
Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
christopherfujino pushed a commit to christopherfujino/flutter that referenced this pull request Sep 1, 2020
christopherfujino added a commit that referenced this pull request Sep 1, 2020
* Update engine hash to 1.20.3
* Re-enable image_list test with updated certificate(good for 3650 days). (#64519)
* [Material] Relanding fix to ensure time picker input mode lays out correctly in RTL (#64097)
* allow null in compute for weak mode (#63515)
* [flutter_tools] fix recursive asset variant issue (#61129)
* [flutter_tool] Handle Windows line endings in packages_test.dart (#63806)
* [flutter_tool] Fix some create_test.dart tests on Windows (#63796)

Co-authored-by: Alexander Aprelev <aam@google.com>
Co-authored-by: Rami <2364772+rami-a@users.noreply.github.com>
Co-authored-by: Alexandre Ardhuin <alexandre.ardhuin@gmail.com>
Co-authored-by: Jonah Williams <jonahwilliams@google.com>
Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
mohammedJ-Sadiq added a commit to mohammedJ-Sadiq/flutter that referenced this pull request Jan 17, 2021
* Update engine hash to 1.20.3
* Re-enable image_list test with updated certificate(good for 3650 days). (flutter#64519)
* [Material] Relanding fix to ensure time picker input mode lays out correctly in RTL (flutter#64097)
* allow null in compute for weak mode (flutter#63515)
* [flutter_tools] fix recursive asset variant issue (flutter#61129)
* [flutter_tool] Handle Windows line endings in packages_test.dart (flutter#63806)
* [flutter_tool] Fix some create_test.dart tests on Windows (flutter#63796)

Co-authored-by: Alexander Aprelev <aam@google.com>
Co-authored-by: Rami <2364772+rami-a@users.noreply.github.com>
Co-authored-by: Alexandre Ardhuin <alexandre.ardhuin@gmail.com>
Co-authored-by: Jonah Williams <jonahwilliams@google.com>
Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong hour/minute order in timePicker in RTL mode
5 participants