-
Notifications
You must be signed in to change notification settings - Fork 27.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Material] Relanding fix to ensure time picker input mode lays out correctly in RTL #64097
Merged
+199
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: internationalization
Supporting other languages or locales. (aka i18n)
f: material design
flutter/packages/flutter/material repository.
framework
flutter/packages/flutter repository. See also f: labels.
labels
Aug 18, 2020
HansMuller
approved these changes
Aug 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
johnsonmh
approved these changes
Aug 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
perclasson
reviewed
Aug 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
perclasson
approved these changes
Aug 19, 2020
13 tasks
smadey
pushed a commit
to smadey/flutter
that referenced
this pull request
Aug 27, 2020
christopherfujino
pushed a commit
to christopherfujino/flutter
that referenced
this pull request
Aug 27, 2020
christopherfujino
added a commit
that referenced
this pull request
Aug 27, 2020
* update engine hash * allow null in compute for weak mode (#63515) * [Material] Relanding fix to ensure time picker input mode lays out correctly in RTL (#64097) * pin customer-testing * [flutter_tool] Handle Windows line endings in packages_test.dart (#63806) * [flutter_tool] Fix some create_test.dart tests on Windows (#63796) Co-authored-by: Alexandre Ardhuin <alexandre.ardhuin@gmail.com> Co-authored-by: Rami <2364772+rami-a@users.noreply.github.com> Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
christopherfujino
pushed a commit
to christopherfujino/flutter
that referenced
this pull request
Sep 1, 2020
christopherfujino
added a commit
that referenced
this pull request
Sep 1, 2020
* Update engine hash to 1.20.3 * Re-enable image_list test with updated certificate(good for 3650 days). (#64519) * [Material] Relanding fix to ensure time picker input mode lays out correctly in RTL (#64097) * allow null in compute for weak mode (#63515) * [flutter_tools] fix recursive asset variant issue (#61129) * [flutter_tool] Handle Windows line endings in packages_test.dart (#63806) * [flutter_tool] Fix some create_test.dart tests on Windows (#63796) Co-authored-by: Alexander Aprelev <aam@google.com> Co-authored-by: Rami <2364772+rami-a@users.noreply.github.com> Co-authored-by: Alexandre Ardhuin <alexandre.ardhuin@gmail.com> Co-authored-by: Jonah Williams <jonahwilliams@google.com> Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
mohammedJ-Sadiq
added a commit
to mohammedJ-Sadiq/flutter
that referenced
this pull request
Jan 17, 2021
* Update engine hash to 1.20.3 * Re-enable image_list test with updated certificate(good for 3650 days). (flutter#64519) * [Material] Relanding fix to ensure time picker input mode lays out correctly in RTL (flutter#64097) * allow null in compute for weak mode (flutter#63515) * [flutter_tools] fix recursive asset variant issue (flutter#61129) * [flutter_tool] Handle Windows line endings in packages_test.dart (flutter#63806) * [flutter_tool] Fix some create_test.dart tests on Windows (flutter#63796) Co-authored-by: Alexander Aprelev <aam@google.com> Co-authored-by: Rami <2364772+rami-a@users.noreply.github.com> Co-authored-by: Alexandre Ardhuin <alexandre.ardhuin@gmail.com> Co-authored-by: Jonah Williams <jonahwilliams@google.com> Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
a: internationalization
Supporting other languages or locales. (aka i18n)
f: material design
flutter/packages/flutter/material repository.
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is re-landing #63599 and it ensures that the hours and minutes are laid out correctly for RTL for the time picker input mode.
In the previous PR, the ":" separator became vertically offset from the hours and minutes because of the addition of a nested
Row
widget that didn't specify the crossAxisAlignment appropriately. So it was reverted in #64094. This PR adds a fix for that.Related Issues
Fixes #63427
Tests
I added the following tests:
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.