Flutter stable framework 1.20.3 cherrypicks #64984

christopherfujino · 2020-08-31T23:28:34Z

Scheduled Cherrypicks

Engine update
- d1bc06f032f9d6c148ea6b96b48261d6f545004f
- Flutter 1.20.3 engine cherrypicks engine#20838
Wrong hour/minute order in timePicker in RTL mode Wrong hour/minute order in timePicker in RTL mode #63427
- 021cf56fc97f96e0571bbb13d2c7a6d66de3beff
- [Material] Relanding fix to ensure time picker input mode lays out correctly in RTL #64097
- Author @rami-a, original approver @HansMuller
Cannot return with NULL from Isolate: Exception: Isolate exited without result or error Cannot return with NULL from Isolate: Exception: Isolate exited without result or error #63590
- afc9509996b334b71f51f625125c232dce649606
- allow null in compute for weak mode #63515
- Author @a14n, original approver @goderbauer
iOS build error: The domain/default pair of [...] does not exist iOS build error: The domain/default pair of (/Runner.app/Frameworks/App.framework/flutter_assets/ios/Flutter/App.framework/Info.plist, CFBundleExecutable) does not exist #57210
- 741608a261e3b6ac3c36c7ad6cdf798f86733d07
- [flutter_tools] fix recursive asset variant issue #61129
- Author @jonahwilliams, original approver @jmagman

Test/Infra-Only Cherrypicks

Update devicelab test certificate
- ed65f5e96cb2437e0315b65df0aba248e3896b45
- Re-enable image_list test with updated certificate(good for 3650 days). #64519
Fix Windows Line endings in tool-tests packages_test.dart
- 1884920e30b8d82f2e6408aae1c2b780349d8d00
- [flutter_tool] Handle Windows line endings in packages_test.dart #63806
Fix more Windows line endings in tool-tests create_test.dart
- f360d8b8e8a7909c65db0d82b5cb07ab4e7cc0ff
- [flutter_tool] Fix some create_test.dart tests on Windows #63796

Presubmit Known Failures

LUCI Linux customer_testing and Windows customer_testing because of Pin all repos we clone from HEAD for CI #57062. In the cirrus config, this test was pinned and is green.
LUCI Linux fuchsia-precache because LUCI try-jobs still running latest recipes LUCI try jobs for release branches should use correct builder/recipes #53371.

Postsubmit Known Failures

LUCI Windows Stable hostonly_devicelab_tests known failure, these are still red on master but ignored by the build dashboard hostonly_devicelab_tests failing consistently on luci #64466.
Devicelab Flutter Gallery v2 tests are known failures Pin version of flutter/gallery in tests #62983 this was pinned upstream in Pin gallery version #62986.
LUCI customer_testing Linux/Windows known failure, will be fixed by pinning repo checkout on LUCI Pin all repos we clone from HEAD for CI #57062
LUCI fuchsia_precache known failure, will be fixed by being able to skip tasks post-submit [infra] No way to skip builders per-branch on post-submit #64975

flutter-dashboard · 2020-08-31T23:28:53Z

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.20-candidate.7. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

…). (flutter#64519) Added instructions on how to regenerate certificate too.

…rrectly in RTL (flutter#64097)

Fixes flutter#45075 Fixes flutter#57210 If an asset was included directly from the project root directory, then the same asset when copied to various output or ephemeral directories would also be picked up as an asset variant. This could cause assets to be recursively copied into asset/build/ephemeral directories, as each time it would run it would pick up all of the previous "variants". The solution is to include project ephemeral directories, in addition to the build directory.

googlebot · 2020-09-01T00:02:34Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

jonahwilliams

LGTM

pcsosinski

approved for branch. don't forget to sign the engine :)

christopherfujino · 2020-09-01T00:08:30Z

approved for branch. don't forget to sign the engine :)

Thanks for checking, I did already.

christopherfujino · 2020-09-01T00:11:37Z

@a14n please look for review, and also CLABot needs consent again :P

HansMuller

LGTM

…tter#63806)

)

a14n · 2020-09-01T04:38:25Z

@googlebot I consent

googlebot · 2020-09-01T04:38:35Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

a14n · 2020-09-01T04:38:37Z

LGTM

rami-a

LGTM for time picker change

christopherfujino · 2020-09-01T17:11:21Z

Re-running framework_tests-misc-windows (it was a timeout downloading from pub).

Update: passed on re-run, everything is green except for expected failures, which I've tracked in the description.

christopherfujino · 2020-09-01T17:11:56Z

Friendly ping @jmagman for the #61129 cherrypick.

jmagman

LGTM

jmagman · 2020-09-01T17:39:27Z

Friendly ping @jmagman for the #61129 cherrypick.

Sorry, thought @jonahwilliams's was enough.

christopherfujino · 2020-09-01T19:05:27Z

Friendly ping @jmagman for the #61129 cherrypick.

Sorry, thought @jonahwilliams's was enough.

Yeah, sorry, I should have been more clear. For extra safety I'm trying out getting multiple reviewers per cherry pick, starting this week.

Speaking of which, @goderbauer could you verify the change to packages/flutter/lib/src/foundation/_isolates_io.dart

HansMuller · 2020-09-01T19:10:01Z

@christopherfujino - Michael is out this week; is there someone else who could LGTM the change to packages/flutter/lib/src/foundation/_isolates_io.dart?

christopherfujino · 2020-09-01T19:20:02Z

@christopherfujino - Michael is out this week; is there someone else who could LGTM the change to packages/flutter/lib/src/foundation/_isolates_io.dart?

Ahh, thanks. In that case, I can LGTM it :)

christopherfujino · 2020-09-01T19:25:11Z

Merging with the failures all known and issues filed, see PR description for details.

* Update engine hash to 1.20.3 * Re-enable image_list test with updated certificate(good for 3650 days). (flutter#64519) * [Material] Relanding fix to ensure time picker input mode lays out correctly in RTL (flutter#64097) * allow null in compute for weak mode (flutter#63515) * [flutter_tools] fix recursive asset variant issue (flutter#61129) * [flutter_tool] Handle Windows line endings in packages_test.dart (flutter#63806) * [flutter_tool] Fix some create_test.dart tests on Windows (flutter#63796) Co-authored-by: Alexander Aprelev <aam@google.com> Co-authored-by: Rami <2364772+rami-a@users.noreply.github.com> Co-authored-by: Alexandre Ardhuin <alexandre.ardhuin@gmail.com> Co-authored-by: Jonah Williams <jonahwilliams@google.com> Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>

Update engine hash to 1.20.3

2f04425

christopherfujino requested a review from jmagman as a code owner August 31, 2020 23:28

googlebot added the cla: yes label Aug 31, 2020

christopherfujino changed the base branch from master to flutter-1.20-candidate.7 August 31, 2020 23:28

flutter-dashboard bot changed the base branch from flutter-1.20-candidate.7 to master August 31, 2020 23:28

christopherfujino changed the base branch from master to flutter-1.20-candidate.7 August 31, 2020 23:29

aam and others added 4 commits August 31, 2020 16:31

Re-enable image_list test with updated certificate(good for 3650 days…

3858c44

…). (flutter#64519) Added instructions on how to regenerate certificate too.

[Material] Relanding fix to ensure time picker input mode lays out co…

742f092

…rrectly in RTL (flutter#64097)

allow null in compute for weak mode (flutter#63515)

cfdbd72

googlebot added cla: no and removed cla: yes labels Sep 1, 2020

flutter-dashboard bot added the d: examples Sample code and demos label Sep 1, 2020

christopherfujino requested review from rami-a, jonahwilliams, a14n, goderbauer, HansMuller and pcsosinski September 1, 2020 00:03

jonahwilliams approved these changes Sep 1, 2020

View reviewed changes

pcsosinski approved these changes Sep 1, 2020

View reviewed changes

HansMuller approved these changes Sep 1, 2020

View reviewed changes

zanderso added 2 commits August 31, 2020 17:28

[flutter_tool] Handle Windows line endings in packages_test.dart (flu…

6c186f6

…tter#63806)

[flutter_tool] Fix some create_test.dart tests on Windows (flutter#63796

9dc3b1a

)

googlebot added cla: yes and removed cla: no labels Sep 1, 2020

rami-a approved these changes Sep 1, 2020

View reviewed changes

a14n approved these changes Sep 1, 2020

View reviewed changes

jmagman approved these changes Sep 1, 2020

View reviewed changes

christopherfujino merged commit 216dee6 into flutter:flutter-1.20-candidate.7 Sep 1, 2020

christopherfujino deleted the cherrypicks-flutter-1.20-candidate.7 branch September 1, 2020 19:25

github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Flutter stable framework 1.20.3 cherrypicks #64984

Flutter stable framework 1.20.3 cherrypicks #64984

christopherfujino commented Aug 31, 2020 •

edited

Loading

flutter-dashboard bot commented Aug 31, 2020

googlebot commented Sep 1, 2020

jonahwilliams left a comment

pcsosinski left a comment

christopherfujino commented Sep 1, 2020

christopherfujino commented Sep 1, 2020

HansMuller left a comment

a14n commented Sep 1, 2020

googlebot commented Sep 1, 2020

a14n commented Sep 1, 2020

rami-a left a comment

christopherfujino commented Sep 1, 2020 •

edited

Loading

christopherfujino commented Sep 1, 2020

jmagman left a comment

jmagman commented Sep 1, 2020

christopherfujino commented Sep 1, 2020

HansMuller commented Sep 1, 2020

christopherfujino commented Sep 1, 2020

christopherfujino commented Sep 1, 2020

Flutter stable framework 1.20.3 cherrypicks #64984

Flutter stable framework 1.20.3 cherrypicks #64984

Conversation

christopherfujino commented Aug 31, 2020 • edited Loading

Scheduled Cherrypicks

Test/Infra-Only Cherrypicks

Presubmit Known Failures

Postsubmit Known Failures

flutter-dashboard bot commented Aug 31, 2020

googlebot commented Sep 1, 2020

jonahwilliams left a comment

Choose a reason for hiding this comment

pcsosinski left a comment

Choose a reason for hiding this comment

christopherfujino commented Sep 1, 2020

christopherfujino commented Sep 1, 2020

HansMuller left a comment

Choose a reason for hiding this comment

a14n commented Sep 1, 2020

googlebot commented Sep 1, 2020

a14n commented Sep 1, 2020

rami-a left a comment

Choose a reason for hiding this comment

christopherfujino commented Sep 1, 2020 • edited Loading

christopherfujino commented Sep 1, 2020

jmagman left a comment

Choose a reason for hiding this comment

jmagman commented Sep 1, 2020

christopherfujino commented Sep 1, 2020

HansMuller commented Sep 1, 2020

christopherfujino commented Sep 1, 2020

christopherfujino commented Sep 1, 2020

christopherfujino commented Aug 31, 2020 •

edited

Loading

christopherfujino commented Sep 1, 2020 •

edited

Loading