assignGear changes #215
assignGear changes #215
Conversation
…eapon]+[2xsmoke/2xfrag]
… to the carbine module
…-guerilla factions
There was a problem hiding this comment.
Partial review (see comments also):
- Headers in some of the _standard files are wrong. For example, f_assignGear_aaf_standard.sqf says "Light Loadout".
- Extra space after addBackpack in some of the _standard and _light "mtrg" classes.
- Light FIA, FIA AK, and Syndicate AR all still have 5 smokes.
| @@ -228,7 +232,7 @@ switch (_typeofUnit) do | |||
| _unit addmagazines [_smokegrenade, 3]; | |||
| _unit addmagazines [_carbinemag, 2]; | |||
| _unit addmagazines [_carbinemag_tr, 2]; | |||
| _unit addmagazines [_MATmag1, 2]; | |||
| _unit addmagazines [_MATmag1, 4]; | |||
There was a problem hiding this comment.
Shouldn't this be an increase in _carbinemag rather than an increase in _MATmag1?
| _unit addmagazines [_MATmag1, 2]; | ||
| _unit addmagazines [_carbinemag, 2]; | ||
| _unit addmagazines [_carbinemag_tr, 2]; | ||
| _unit addmagazines [_MATmag1, 4]; |
There was a problem hiding this comment.
Same as AAF, should this not be 4 _carbinemag?
…ead of carbinemag in a previous commit.
There was a problem hiding this comment.
Looks good as far as I can tell. I think all the changes documented in #213 have been applied and that #210, #211. and #214 have been fixed, but given the size of these changes it's hard to be sure. Same goes for testing, aside from basic "does anything break" testing this can only really be tested 'in the field' via MM feedback. What I can say for sure is that the _light and _standard loadouts are now synchronised between factions and each other (but not that they are correctly synchronised).
As such, I am happy to merge this. @shadow-fa Do you want someone else to review before I merge this?
This pull request fixes the following issues: