Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding 3IFB to assignGear #221

Merged
merged 4 commits into from
Mar 18, 2019
Merged

adding 3IFB to assignGear #221

merged 4 commits into from
Mar 18, 2019

Conversation

shadow-fa
Copy link
Collaborator

@shadow-fa shadow-fa commented Feb 25, 2019

See #212.

I took the syndikat files from #215 as a base and adjusted the Sniper/Spotter magazine counts to balance them wrt to the other factions and their magazines.
f_assignGear_3IFB.sqf is from costno.

Open issues for this or a future PR:

Co-authored-by: costno <costno16@gmail.com>
@shadow-fa shadow-fa marked this pull request as ready for review March 16, 2019 15:50
@shadow-fa shadow-fa changed the title Issue 212: assignGear: adding 3IFB adding 3IFB to assignGear Mar 16, 2019
Co-Authored-By: shadow-fa <shadow-fa@users.noreply.github.com>
Co-Authored-By: shadow-fa <shadow-fa@users.noreply.github.com>
@shadow-fa shadow-fa mentioned this pull request Mar 16, 2019
19 tasks
@SamLex SamLex added the PR:Review In Progress PR is under code review label Mar 16, 2019
@SamLex SamLex requested a review from NikkoJT March 16, 2019 16:54
SamLex
SamLex previously approved these changes Mar 18, 2019
Copy link
Member

@SamLex SamLex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell, just a few small typos. @NikkoJT Don't know if you want to have a quick look at this from a gear perspective?

@SamLex SamLex removed the PR:Review In Progress PR is under code review label Mar 18, 2019
Co-Authored-By: shadow-fa <shadow-fa@users.noreply.github.com>
Copy link
Member

@SamLex SamLex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving for typo fixes.

@SamLex SamLex merged commit 1b995f5 into folkarps:dev Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants