Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.8.3 #336

Merged
merged 2 commits into from
Feb 3, 2025
Merged

v0.8.3 #336

merged 2 commits into from
Feb 3, 2025

Conversation

achim-k
Copy link
Collaborator

@achim-k achim-k commented Feb 3, 2025

Changelog

@achim-k achim-k requested a review from jtbandes February 3, 2025 14:06
@achim-k achim-k merged commit e4af8e1 into main Feb 3, 2025
9 checks passed
@achim-k achim-k deleted the achim/v0.8.3 branch February 3, 2025 14:36
MrBlenny added a commit to Greenroom-Robotics/ros-foxglove-bridge that referenced this pull request Feb 20, 2025
* Fix "no matching function" error on yocto kirkstone (foxglove#331)

### Changelog
None
### Docs
None
### Description

foxglove#330 Fixes for Yocto issue

Fix for compilation error on yocto Kirkstone.

> error: no matching function for call to 'max(long unsigned int, size_t)

* bump to 0.8.2 (foxglove#332)

Bumping to 0.8.2 for foxglove#331

* Add missing functional include in message_definition_cache.cpp (foxglove#334)

### Changelog

message_definition_cache.cpp uses std::function, so it should include
the functional STL header

### Docs

None

### Description

message_definition_cache.cpp uses std::function, so it should include
the functional STL header

* add best_effort_qos_topic_whitelist param (foxglove#329)

### Changelog
Adds a `qos_reliablity` param to the ros2 bridge that allows the default
reliability to be set via param. Defaults to "automatic" to retain
existing behavior.

### Docs

N/A

### Description

The web-socket bridge runs on TCP which causes issues on flakey internet
connections. There is some discussion here:
https://github.com/orgs/foxglove/discussions/15

This PR adds the ability to specify "qos_reliability" of "best_effort"
which is useful when running a bridge on a different computer to the
robot for example:

**ROBOT COMPUTER** -> DDS/UDP -> **REMOTE COMPUTER** -> Websocket/TCP ->
Foxglove / Browser

---------

Co-authored-by: Hans-Joachim Krauch <achim-k@users.noreply.github.com>

* v0.8.3 (foxglove#336)

### Changelog
* add best_effort_qos_topic_whitelist param (foxglove#329)
* Add missing functional include in message_definition_cache.cpp (foxglove#334)

* feat: add send_buffer_queue param

* chore: lint fixes

---------

Co-authored-by: Graham Harison <gupyfish@gmail.com>
Co-authored-by: Jacob Bandes-Storch <jacob@foxglove.dev>
Co-authored-by: Silvio Traversaro <silvio@traversaro.it>
Co-authored-by: Hans-Joachim Krauch <achim-k@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant