Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors building foxglove-bridge 0.7.7-1 with Yocto (kirkstone) and ros2 humble #330

Closed
grahas opened this issue Dec 11, 2024 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@grahas
Copy link
Contributor

grahas commented Dec 11, 2024

Description
When building with yocto the following error is seen

/home/axcend/OSTL-k/build-openstlinuxweston-stm32mp1/tmp-glibc/work/cortexa7t2hf-neon-vfpv4-oe-linux-gnueabi/foxglove-bridge/0.7.7-1-r0/git/ros2_foxglove_bridge/src/ros2_foxglove_bridge.cpp:482:50: error: no matching function for call to 'max(long unsigned int, size_t)' 482 | const size_t publisherHistoryDepth = std::max(1ul, qos.depth());

  • Version: 0.7.7-1
  • Platform: target is arm-oe-linux-gnueabi

Steps To Reproduce

bitbake foxglove-bridge

Expected Behavior
no build error

@grahas grahas added the bug Something isn't working label Dec 11, 2024
Copy link

linear bot commented Dec 11, 2024

grahas added a commit to grahas/ros-foxglove-bridge that referenced this issue Dec 11, 2024
@jtbandes
Copy link
Member

Thanks – I believe you reported the same issue in Discord as well. If you verify the fix works for you then please submit a PR and we can review+merge.

@grahas grahas mentioned this issue Dec 11, 2024
jtbandes pushed a commit that referenced this issue Dec 12, 2024
### Changelog
None
### Docs
None
### Description

#330 Fixes for Yocto issue

Fix for compilation error on yocto Kirkstone.

> error: no matching function for call to 'max(long unsigned int, size_t)
@defunctzombie
Copy link
Contributor

Fixed in #331

MrBlenny added a commit to Greenroom-Robotics/ros-foxglove-bridge that referenced this issue Feb 20, 2025
* Fix "no matching function" error on yocto kirkstone (foxglove#331)

### Changelog
None
### Docs
None
### Description

foxglove#330 Fixes for Yocto issue

Fix for compilation error on yocto Kirkstone.

> error: no matching function for call to 'max(long unsigned int, size_t)

* bump to 0.8.2 (foxglove#332)

Bumping to 0.8.2 for foxglove#331

* Add missing functional include in message_definition_cache.cpp (foxglove#334)

### Changelog

message_definition_cache.cpp uses std::function, so it should include
the functional STL header

### Docs

None

### Description

message_definition_cache.cpp uses std::function, so it should include
the functional STL header

* add best_effort_qos_topic_whitelist param (foxglove#329)

### Changelog
Adds a `qos_reliablity` param to the ros2 bridge that allows the default
reliability to be set via param. Defaults to "automatic" to retain
existing behavior.

### Docs

N/A

### Description

The web-socket bridge runs on TCP which causes issues on flakey internet
connections. There is some discussion here:
https://github.com/orgs/foxglove/discussions/15

This PR adds the ability to specify "qos_reliability" of "best_effort"
which is useful when running a bridge on a different computer to the
robot for example:

**ROBOT COMPUTER** -> DDS/UDP -> **REMOTE COMPUTER** -> Websocket/TCP ->
Foxglove / Browser

---------

Co-authored-by: Hans-Joachim Krauch <achim-k@users.noreply.github.com>

* v0.8.3 (foxglove#336)

### Changelog
* add best_effort_qos_topic_whitelist param (foxglove#329)
* Add missing functional include in message_definition_cache.cpp (foxglove#334)

* feat: add send_buffer_queue param

* chore: lint fixes

---------

Co-authored-by: Graham Harison <gupyfish@gmail.com>
Co-authored-by: Jacob Bandes-Storch <jacob@foxglove.dev>
Co-authored-by: Silvio Traversaro <silvio@traversaro.it>
Co-authored-by: Hans-Joachim Krauch <achim-k@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

3 participants