Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: serial / batch barcode scanner #39114

Merged
merged 1 commit into from
Jan 4, 2024
Merged

fix: serial / batch barcode scanner #39114

merged 1 commit into from
Jan 4, 2024

Conversation

rohitwaghchaure
Copy link
Collaborator

@rohitwaghchaure rohitwaghchaure commented Jan 3, 2024 •
edited
Loading

Issue

On serial/batch scanning, the system opens a popup to add serial/batch numbers. However, this can slow down the data entry especially when the volume is high.

serial_batch_scanner_issue

Why pop-up
After normalizing the serial number field, the user is required to compulsorily create the serial and batch bundle to generate stock transactions for the serial/batches. The issue with the barcode scanner was storing the scanned serial/batches. In this case, we couldn't create the serial and batch bundle immediately because the main stock transaction had not been saved yet and therefore the popup was added in the earlier solution.

Solution

To address the popup problem, the solution is as follows:

  • If the document has not been saved and the user has scanned the serial/batches, then the system will store the information in LocalStorage.
  • On saving of the transaction, the system will first create the serial and batch bundle, linked it with the current stock transaction and then clear the LocalStorage serial/batches related to the current stock transaction.

serial_batch_scanner

fixed #39077
fixed #39095

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. stock labels Jan 3, 2024
@rohitwaghchaure rohitwaghchaure mentioned this pull request Jan 3, 2024
Closed
@rohitwaghchaure rohitwaghchaure force-pushed the fixed-serial-batch-scanner-bundle branch from cd8dbd1 to b13445c Compare January 3, 2024 12:32
@rohitwaghchaure rohitwaghchaure force-pushed the fixed-serial-batch-scanner-bundle branch from b13445c to 758bb26 Compare January 4, 2024 09:03
@rohitwaghchaure rohitwaghchaure merged commit f09e213 into frappe:develop Jan 4, 2024
13 checks passed
@rohitwaghchaure rohitwaghchaure added backport version-15-hotfix and removed accounts stock needs-tests This PR needs automated unit-tests. labels Jan 4, 2024
mergify bot pushed a commit that referenced this pull request Jan 4, 2024
@rohitwaghchaure @mergify
fix: serial / batch barcode scanner (#39114)
4dd51f7 
(cherry picked from commit f09e213)
@mergify mergify bot mentioned this pull request Jan 4, 2024
Merged
rohitwaghchaure added a commit that referenced this pull request Jan 4, 2024
@mergify @rohitwaghchaure
fix: serial / batch barcode scanner (backport #39114) (#39143)
2db1e1a 
fix: serial / batch barcode scanner (#39114)

(cherry picked from commit f09e213)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Jan 10, 2024
@frappe-bot
chore(release): Bumped to Version 15.10.0
1dc85fc 
# [15.10.0](v15.9.1...v15.10.0) (2024-01-10)

### Bug Fixes

* add expected_start_date in sort by ([b064944](b064944))
* Add name to Hungary - Chart of Accounts for Microenterprises json ([0784488](0784488))
* add read permission to Buying Settings ([e62dd0d](e62dd0d))
* bank transction status upon reconciliation ([277aa7b](277aa7b))
* BOM replace tool does not update exploded items of root (backport [#39244](#39244)) ([#39250](#39250)) ([0898ea5](0898ea5))
* Creating Asset Activity while Importing Asset ([#39113](#39113)) ([5e46937](5e46937))
* don't set rate for non-stock item in Internal Transfer (backport [#39140](#39140)) ([#39169](#39169)) ([f3882a8](f3882a8))
* Duplicate Closing Stock Balance (backport [#39262](#39262)) ([#39264](#39264)) ([78c65f2](78c65f2))
* duplicate entry for serial / batch creation (backport [#39188](#39188)) ([#39192](#39192)) ([672e6d6](672e6d6))
* **Employee:** treeview ([#39126](#39126)) ([6020c8e](6020c8e))
* FG Item incorrect qty in the work order (backport [#39200](#39200)) ([#39211](#39211)) ([abc99f8](abc99f8))
* flaky demo test case (backport [#39135](#39135)) ([#39198](#39198)) ([3caf462](3caf462))
* Ignore asset qty and status validation while cancelling LCV ([87d1b0f](87d1b0f))
* ignore cancelled payments in Sales/Purchase Register ([9e1b443](9e1b443))
* Ignore UP on "allowed to transact with" ([#39103](#39103)) ([aad39cf](aad39cf))
* improved validation message ([e89dce7](e89dce7))
* incorrect indicator title for portal sales order (backport [#39247](#39247)) ([#39255](#39255)) ([9f793b9](9f793b9))
* incorrect outstanding amt validation on advance as liability ([51d8a7a](51d8a7a))
* Introduced company field to show amounts in company currency ([1d2e831](1d2e831))
* inventory dimension negative stock validation (backport [#39149](#39149)) ([#39151](#39151)) ([82b96d3](82b96d3))
* possible key error on Financial ratios report ([16269b0](16269b0))
* possible typeerror on transaction.js ([fec892c](fec892c))
* projects website list visible for guests and all logged in customers (backport [#39164](#39164)) ([#39273](#39273)) ([5d6bc96](5d6bc96)), closes [#39009](#39009)
* Purchase date and amount is not mandatory for composite asset creation ([d6d54ed](d6d54ed))
* Resolved conflict ([afefae0](afefae0))
* serial / batch barcode scanner (backport [#39114](#39114)) ([#39143](#39143)) ([2db1e1a](2db1e1a))
* Set asset purchase amount based on qty and valuation_rate ([f0070b4](f0070b4))
* set parent doctype on chart (backport [#39286](#39286)) ([#39288](#39288)) ([fe973a4](fe973a4))
* Show maintain-stock and is-fixed-asset checkbox in item quick entry dialog ([50300b9](50300b9))
* Show timesheet table after fetching data from timesheet (backport [#39275](#39275)) ([#39281](#39281)) ([2598f8e](2598f8e))
* skip rate validation for return `DN Items` with `Moving Average` valuation (backport [#39242](#39242)) ([#39266](#39266)) ([f00a6f6](f00a6f6))
* Subscription update patch ([7640fea](7640fea))
* total allocated percentage for sales team issue ([756c062](756c062))
* TypeError is pricing rules (backport [#39252](#39252)) ([#39260](#39260)) ([bb6025c](bb6025c))
* typerror on multi select dialog ([54a0df5](54a0df5))
* update Maintenance Schedule status on Maintenance Visit submit (backport [#39167](#39167)) ([#39186](#39186)) ([926850d](926850d))
* update status on manual allocation ([a147e29](a147e29))
* **UX:** dont override framework's permission check messages (backport [#39118](#39118)) ([#39120](#39120)) ([40ec5ff](40ec5ff))

### Features

* provision to close SCO (backport [#39127](#39127)) ([#39144](#39144)) ([b192ddd](b192ddd))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007

@s-aga-r s-aga-r Awaiting requested review from s-aga-r

Assignees
No one assigned
Labels
backport version-15-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify SABB creation for Purchase Invoices Batch and serial feature ISSUE
1 participant
@rohitwaghchaure