Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provision to close SCO #39127

Merged
merged 9 commits into from
Jan 4, 2024
Merged

feat: provision to close SCO #39127

merged 9 commits into from
Jan 4, 2024

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Jan 3, 2024

Closes: #38702

no-docs

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jan 3, 2024
@s-aga-r
Copy link
Contributor Author

s-aga-r commented Jan 3, 2024

  • Update qty on SCO close and re-open.
  • Close SCO on PO Close (?)
  • Reopen SCO on PO Reopen (?)

@s-aga-r s-aga-r removed the needs-tests This PR needs automated unit-tests. label Jan 3, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 85 lines in your changes are missing coverage. Please review.

Comparison is base (33b631e) 60.03% compared to head (cdd5441) 60.08%.
Report is 48 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #39127      +/-   ##
===========================================
+ Coverage    60.03%   60.08%   +0.04%     
===========================================
  Files          761      761              
  Lines        70122    70301     +179     
===========================================
+ Hits         42099    42241     +142     
- Misses       28023    28060      +37     
Files Coverage Δ
...xt/accounts/doctype/journal_entry/journal_entry.py 66.54% <100.00%> (+0.51%) ⬆️
...ounts/doctype/purchase_invoice/purchase_invoice.py 70.30% <100.00%> (+0.12%) ⬆️
...next/accounts/doctype/subscription/subscription.py 77.97% <100.00%> (+0.25%) ⬆️
erpnext/accounts/party.py 81.42% <100.00%> (+0.30%) ⬆️
erpnext/controllers/sales_and_purchase_return.py 91.18% <100.00%> (+0.57%) ⬆️
erpnext/hooks.py 100.00% <100.00%> (ø)
erpnext/manufacturing/doctype/bom/bom.py 73.32% <100.00%> (+0.75%) ⬆️
erpnext/regional/united_arab_emirates/utils.py 38.38% <100.00%> (ø)
erpnext/setup/install.py 23.14% <ø> (-0.07%) ⬇️
erpnext/setup/setup_wizard/setup_wizard.py 75.86% <ø> (ø)
... and 25 more

... and 4 files with indirect coverage changes

@s-aga-r s-aga-r marked this pull request as ready for review January 4, 2024 11:08
@s-aga-r s-aga-r merged commit 610d4f5 into frappe:develop Jan 4, 2024
13 of 14 checks passed
s-aga-r added a commit that referenced this pull request Jan 4, 2024
* feat: provision to close SCO

(cherry picked from commit 5e2669f)

* fix: don't allow to submit/cancel SCR against a closed SCO

(cherry picked from commit 9e97347)

* fix: don't allow to submit/cancel SE against a closed SCO

(cherry picked from commit 5bc2035)

* fix(ux): filter closed SCO in `Get Items From` dialog

(cherry picked from commit bb839b2)

* fix: don't close PO on SCO close

(cherry picked from commit 0d01bd8)

* fix: update qty on SCO status change

(cherry picked from commit 245effc)

* fix: don't allow to reopen SCO if PO is closed

(cherry picked from commit 784b6dc)

* fix: auto close and reopen SCO based on PO status

(cherry picked from commit 0819675)

* fix(text): test_update_status

(cherry picked from commit cdd5441)

---------

Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Jan 10, 2024
# [15.10.0](v15.9.1...v15.10.0) (2024-01-10)

### Bug Fixes

* add expected_start_date in sort by ([b064944](b064944))
* Add name to Hungary - Chart of Accounts for Microenterprises json ([0784488](0784488))
* add read permission to Buying Settings ([e62dd0d](e62dd0d))
* bank transction status upon reconciliation ([277aa7b](277aa7b))
* BOM replace tool does not update exploded items of root (backport [#39244](#39244)) ([#39250](#39250)) ([0898ea5](0898ea5))
* Creating Asset Activity while Importing Asset ([#39113](#39113)) ([5e46937](5e46937))
* don't set rate for non-stock item in Internal Transfer (backport [#39140](#39140)) ([#39169](#39169)) ([f3882a8](f3882a8))
* Duplicate Closing Stock Balance (backport [#39262](#39262)) ([#39264](#39264)) ([78c65f2](78c65f2))
* duplicate entry for serial / batch creation (backport [#39188](#39188)) ([#39192](#39192)) ([672e6d6](672e6d6))
* **Employee:** treeview ([#39126](#39126)) ([6020c8e](6020c8e))
* FG Item incorrect qty in the work order (backport [#39200](#39200)) ([#39211](#39211)) ([abc99f8](abc99f8))
* flaky demo test case (backport [#39135](#39135)) ([#39198](#39198)) ([3caf462](3caf462))
* Ignore asset qty and status validation while cancelling LCV ([87d1b0f](87d1b0f))
* ignore cancelled payments in Sales/Purchase Register ([9e1b443](9e1b443))
* Ignore UP on "allowed to transact with" ([#39103](#39103)) ([aad39cf](aad39cf))
* improved validation message ([e89dce7](e89dce7))
* incorrect indicator title for portal sales order (backport [#39247](#39247)) ([#39255](#39255)) ([9f793b9](9f793b9))
* incorrect outstanding amt validation on advance as liability ([51d8a7a](51d8a7a))
* Introduced company field to show amounts in company currency ([1d2e831](1d2e831))
* inventory dimension negative stock validation (backport [#39149](#39149)) ([#39151](#39151)) ([82b96d3](82b96d3))
* possible key error on Financial ratios report ([16269b0](16269b0))
* possible typeerror on transaction.js ([fec892c](fec892c))
* projects website list visible for guests and all logged in customers (backport [#39164](#39164)) ([#39273](#39273)) ([5d6bc96](5d6bc96)), closes [#39009](#39009)
* Purchase date and amount is not mandatory for composite asset creation ([d6d54ed](d6d54ed))
* Resolved conflict ([afefae0](afefae0))
* serial / batch barcode scanner (backport [#39114](#39114)) ([#39143](#39143)) ([2db1e1a](2db1e1a))
* Set asset purchase amount based on qty and valuation_rate ([f0070b4](f0070b4))
* set parent doctype on chart (backport [#39286](#39286)) ([#39288](#39288)) ([fe973a4](fe973a4))
* Show maintain-stock and is-fixed-asset checkbox in item quick entry dialog ([50300b9](50300b9))
* Show timesheet table after fetching data from timesheet (backport [#39275](#39275)) ([#39281](#39281)) ([2598f8e](2598f8e))
* skip rate validation for return `DN Items` with `Moving Average` valuation (backport [#39242](#39242)) ([#39266](#39266)) ([f00a6f6](f00a6f6))
* Subscription update patch ([7640fea](7640fea))
* total allocated percentage for sales team issue ([756c062](756c062))
* TypeError is pricing rules (backport [#39252](#39252)) ([#39260](#39260)) ([bb6025c](bb6025c))
* typerror on multi select dialog ([54a0df5](54a0df5))
* update Maintenance Schedule status on Maintenance Visit submit (backport [#39167](#39167)) ([#39186](#39186)) ([926850d](926850d))
* update status on manual allocation ([a147e29](a147e29))
* **UX:** dont override framework's permission check messages (backport [#39118](#39118)) ([#39120](#39120)) ([40ec5ff](40ec5ff))

### Features

* provision to close SCO (backport [#39127](#39127)) ([#39144](#39144)) ([b192ddd](b192ddd))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to close (partially delivered) Subcontracting Order
1 participant