feat: reference for POS SI payments #39523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #39523 +/- ##
===========================================
+ Coverage 60.08% 60.13% +0.04%
===========================================
Files 757 757
Lines 70447 70611 +164
===========================================
+ Hits 42331 42459 +128
- Misses 28116 28152 +36
|
GursheenK
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
mergify bot
pushed a commit
that referenced
this pull request
Feb 3, 2024
* feat: reference field in SI payment * fix: document link for pos si * refactor: pos invoice queries (cherry picked from commit d9a72c1)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
# [15.12.0](v15.11.1...v15.12.0) (2024-02-06) ### Bug Fixes * Blanket Order Ordered Quantity (backport [#39725](#39725)) ([#39739](#39739)) ([b126720](b126720)) * conditionally display show btn setting ([e931432](e931432)) * correctly calculate diff amount for included taxes ([#39655](#39655)) ([7f4cd3c](7f4cd3c)) * do not throw validation for cancelled sle ([02f56ee](02f56ee)) * don't overwrite existing terms in transaction ([dcdd3e8](dcdd3e8)) * Exchange rate on MR to PO creation for muticurrency POs ([#39646](#39646)) ([29eb090](29eb090)) * fetch/change tax template on basis of base_net_rate instead of net_rate ([#39448](#39448)) ([d7c7748](d7c7748)) * incorrect landed cost voucher amount ([a40864d](a40864d)) * out of range for valuation_rate column in SE (backport [#39687](#39687)) ([#39691](#39691)) ([41e4632](41e4632)) * Percentage handling in queries ([#39692](#39692)) ([e76f598](e76f598)) * **portal:** show PO pay button if payments installed ([cea4ed6](cea4ed6)) * Pricing rule application/removal on qty change ([#39084](#39084)) ([f310707](f310707)) * production plan date filters for orders (backport [#39702](#39702)) ([#39720](#39720)) ([3eac436](3eac436)) * remove applied pricing rule on qty change (backport [#39688](#39688)) ([#39737](#39737)) ([f246684](f246684)) * remove file from the disk after the completion of reposting ([b582e9c](b582e9c)) * show warehouse title field in sales docs (backport [#39746](#39746)) ([#39755](#39755)) ([53992de](53992de)) * update company in serial no doc (backport [#39733](#39733)) ([#39747](#39747)) ([00e86bf](00e86bf)) * use old serial / batch fields to make serial batch bundle ([282c19e](282c19e)) * **work order:** resolve type error during job card creation (backport [#39713](#39713)) ([#39714](#39714)) ([5fe40ac](5fe40ac)) ### Features * copy emails from lead to customer ([#38647](#38647)) ([986273b](986273b)) * make material request for job card from workstation dashboard ([3bef12c](3bef12c)) * Period-wise closing entries for TB ([#39712](#39712)) ([1822325](1822325)) * reference for POS SI payments ([#39523](#39523)) ([4ee8cf3](4ee8cf3)) * visual plant floor ([75bd1e6](75bd1e6)) ### Performance Improvements * memory consumption for the stock balance report ([#39626](#39626)) ([5e29aab](5e29aab)) * Move dimension validation out of GL Entry doctype ([#39730](#39730)) ([451c288](451c288)) * timeout for auto material request through reorder level ([1b2831b](1b2831b)) * timeout while submitting the purchase receipt entry ([55a8326](55a8326))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a Sales Invoice is created with
is_posenabled and the payments are mentioned in the Sales Invoice Payment table, no reference ID is captured in the table so when these payments are fetched in the Bank Clearance Tool, it becomes hard to correctly distinguish them from each other.Changes
no-docs