Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Exchange rate on MR to PO creation for muticurrency POs #39646

Merged
merged 1 commit into from
Jan 31, 2024
Merged

fix: Exchange rate on MR to PO creation for muticurrency POs #39646

merged 1 commit into from
Jan 31, 2024

Conversation

deepeshgarg007
Copy link
Member

No description provided.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jan 30, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (079cd30) 60.19% compared to head (05bf1d6) 60.13%.
Report is 23 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #39646      +/-   ##
===========================================
- Coverage    60.19%   60.13%   -0.07%     
===========================================
  Files          757      758       +1     
  Lines        70799    70952     +153     
===========================================
+ Hits         42620    42664      +44     
- Misses       28179    28288     +109
Files Coverage Δ
erpnext/manufacturing/doctype/bom/bom.py 73.35% <100.00%> (+0.03%) ⬆️
...stock/doctype/material_request/material_request.py 69.76% <100.00%> (+0.08%) ⬆️

... and 9 files with indirect coverage changes

@deepeshgarg007 deepeshgarg007 merged commit cfd1666 into frappe:develop Jan 31, 2024
15 checks passed
mergify bot pushed a commit that referenced this pull request Jan 31, 2024
@deepeshgarg007 @mergify
fix: Exchange rate on MR to PO creation for muticurrency POs (#39646)
3385175 
(cherry picked from commit cfd1666)
@mergify mergify bot mentioned this pull request Jan 31, 2024
Merged
mergify bot pushed a commit that referenced this pull request Jan 31, 2024
@deepeshgarg007 @mergify
fix: Exchange rate on MR to PO creation for muticurrency POs (#39646)
68f53e7 
(cherry picked from commit cfd1666)
@mergify mergify bot mentioned this pull request Jan 31, 2024
Merged
deepeshgarg007 added a commit that referenced this pull request Jan 31, 2024
@mergify @deepeshgarg007
fix: Exchange rate on MR to PO creation for muticurrency POs (#39646)
4dc5d9a 
fix: Exchange rate on MR to PO creation for muticurrency POs (#39646)

(cherry picked from commit cfd1666)

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
deepeshgarg007 added a commit that referenced this pull request Jan 31, 2024
@mergify @deepeshgarg007
fix: Exchange rate on MR to PO creation for muticurrency POs (#39646)
29eb090 
fix: Exchange rate on MR to PO creation for muticurrency POs (#39646)

(cherry picked from commit cfd1666)

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Feb 6, 2024
@frappe-bot
chore(release): Bumped to Version 14.62.0
9a8a956 
# [14.62.0](v14.61.4...v14.62.0) (2024-02-06)

### Bug Fixes

* Blanket Order Ordered Quantity (backport [#39725](#39725)) ([#39738](#39738)) ([44c09de](44c09de))
* correctly calculate diff amount for included taxes ([#39655](#39655)) ([350b2cd](350b2cd))
* don't overwrite existing terms in transaction ([#39519](#39519)) ([e49f8d5](e49f8d5))
* Exchange rate on MR to PO creation for muticurrency POs ([#39646](#39646)) ([4dc5d9a](4dc5d9a))
* incorrect landed cost voucher amount ([4a609d8](4a609d8))
* remove applied pricing rule on qty change (backport [#39688](#39688)) ([#39736](#39736)) ([46ac4f4](46ac4f4))
* show warehouse title field in sales docs (backport [#39746](#39746)) ([#39754](#39754)) ([a6067c6](a6067c6))

### Features

* copy emails from lead to customer ([#38647](#38647)) ([7952bf4](7952bf4))
* New financial views - Growth and margin views for P&L and balance sheet (backport [#39588](#39588)) ([#39601](#39601)) ([3808ddb](3808ddb))

### Performance Improvements

* memory consumption for the stock balance report ([#39626](#39626)) ([b32848d](b32848d))
* Move dimension validation out of GL Entry doctype ([#39730](#39730)) ([7691256](7691256))
* timeout for auto material request through reorder level ([85e6b39](85e6b39))
* timeout while submitting the purchase receipt entry ([a1a70bb](a1a70bb))

### Reverts

* Revert "feat: New financial views - Growth and margin views for P&L and balance sheet (#39588)"  ([f01308b](f01308b)), closes [#39588](#39588)
frappe-pr-bot pushed a commit that referenced this pull request Feb 6, 2024
@frappe-bot
chore(release): Bumped to Version 15.12.0
2ba283d 
# [15.12.0](v15.11.1...v15.12.0) (2024-02-06)

### Bug Fixes

* Blanket Order Ordered Quantity (backport [#39725](#39725)) ([#39739](#39739)) ([b126720](b126720))
* conditionally display show btn setting ([e931432](e931432))
* correctly calculate diff amount for included taxes ([#39655](#39655)) ([7f4cd3c](7f4cd3c))
* do not throw validation for cancelled sle ([02f56ee](02f56ee))
* don't overwrite existing terms in transaction ([dcdd3e8](dcdd3e8))
* Exchange rate on MR to PO creation for muticurrency POs ([#39646](#39646)) ([29eb090](29eb090))
* fetch/change tax template on basis of base_net_rate instead of net_rate ([#39448](#39448)) ([d7c7748](d7c7748))
* incorrect landed cost voucher amount ([a40864d](a40864d))
* out of range for valuation_rate column in SE (backport [#39687](#39687)) ([#39691](#39691)) ([41e4632](41e4632))
* Percentage handling in queries ([#39692](#39692)) ([e76f598](e76f598))
* **portal:** show PO pay button if payments installed ([cea4ed6](cea4ed6))
* Pricing rule application/removal on qty change ([#39084](#39084)) ([f310707](f310707))
* production plan date filters for orders (backport [#39702](#39702)) ([#39720](#39720)) ([3eac436](3eac436))
* remove applied pricing rule on qty change (backport [#39688](#39688)) ([#39737](#39737)) ([f246684](f246684))
* remove file from the disk after the completion of reposting ([b582e9c](b582e9c))
* show warehouse title field in sales docs (backport [#39746](#39746)) ([#39755](#39755)) ([53992de](53992de))
* update company in serial no doc (backport [#39733](#39733)) ([#39747](#39747)) ([00e86bf](00e86bf))
* use old serial / batch fields to make serial batch bundle ([282c19e](282c19e))
* **work order:** resolve type error during job card creation (backport [#39713](#39713)) ([#39714](#39714)) ([5fe40ac](5fe40ac))

### Features

* copy emails from lead to customer ([#38647](#38647)) ([986273b](986273b))
* make material request for job card from workstation dashboard ([3bef12c](3bef12c))
* Period-wise closing entries for TB ([#39712](#39712)) ([1822325](1822325))
* reference for POS SI payments ([#39523](#39523)) ([4ee8cf3](4ee8cf3))
* visual plant floor ([75bd1e6](75bd1e6))

### Performance Improvements

* memory consumption for the stock balance report ([#39626](#39626)) ([5e29aab](5e29aab))
* Move dimension validation out of GL Entry doctype ([#39730](#39730)) ([451c288](451c288))
* timeout for auto material request through reorder level ([1b2831b](1b2831b))
* timeout while submitting the purchase receipt entry ([55a8326](55a8326))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

@s-aga-r s-aga-r Awaiting requested review from s-aga-r

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deepeshgarg007