Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: production plan date filters for orders #39702

Merged
merged 1 commit into from
Feb 4, 2024
Merged

fix: production plan date filters for orders #39702

merged 1 commit into from
Feb 4, 2024

Conversation

GursheenK
Copy link
Member

Resolves #39673

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Feb 2, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (1e15a3c) 60.13% compared to head (7c15c6e) 60.13%.
Report is 9 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #39702   +/-   ##
========================================
  Coverage    60.13%   60.13%           
========================================
  Files          758      758           
  Lines        70963    70963           
========================================
+ Hits         42671    42672    +1     
+ Misses       28292    28291    -1
Files Coverage Δ
...t/accounts/report/general_ledger/general_ledger.py 70.49% <100.00%> (ø)
erpnext/controllers/taxes_and_totals.py 95.17% <ø> (ø)
...cturing/doctype/production_plan/production_plan.py 80.70% <ø> (ø)
erpnext/stock/get_item_details.py 83.04% <100.00%> (ø)
...ement_of_accounts/process_statement_of_accounts.py 54.77% <50.00%> (ø)
erpnext/accounts/utils.py 74.47% <50.00%> (ø)
erpnext/accounts/doctype/account/account.py 69.48% <55.55%> (ø)

... and 1 file with indirect coverage changes

@GursheenK GursheenK marked this pull request as ready for review February 3, 2024 07:36
@s-aga-r s-aga-r merged commit 407045a into frappe:develop Feb 4, 2024
15 checks passed
mergify bot pushed a commit that referenced this pull request Feb 4, 2024
@GursheenK @mergify
fix: production plan date filters for orders (#39702)
eb2a442 
(cherry picked from commit 407045a)
@mergify mergify bot mentioned this pull request Feb 4, 2024
Merged
s-aga-r pushed a commit that referenced this pull request Feb 5, 2024
@mergify @GursheenK
fix: production plan date filters for orders (backport #39702) (#39720)
3eac436 
fix: production plan date filters for orders (#39702)

(cherry picked from commit 407045a)

Co-authored-by: Gursheen Kaur Anand <40693548+GursheenK@users.noreply.github.com>
frappe-pr-bot pushed a commit that referenced this pull request Feb 6, 2024
@frappe-bot
chore(release): Bumped to Version 15.12.0
2ba283d 
# [15.12.0](v15.11.1...v15.12.0) (2024-02-06)

### Bug Fixes

* Blanket Order Ordered Quantity (backport [#39725](#39725)) ([#39739](#39739)) ([b126720](b126720))
* conditionally display show btn setting ([e931432](e931432))
* correctly calculate diff amount for included taxes ([#39655](#39655)) ([7f4cd3c](7f4cd3c))
* do not throw validation for cancelled sle ([02f56ee](02f56ee))
* don't overwrite existing terms in transaction ([dcdd3e8](dcdd3e8))
* Exchange rate on MR to PO creation for muticurrency POs ([#39646](#39646)) ([29eb090](29eb090))
* fetch/change tax template on basis of base_net_rate instead of net_rate ([#39448](#39448)) ([d7c7748](d7c7748))
* incorrect landed cost voucher amount ([a40864d](a40864d))
* out of range for valuation_rate column in SE (backport [#39687](#39687)) ([#39691](#39691)) ([41e4632](41e4632))
* Percentage handling in queries ([#39692](#39692)) ([e76f598](e76f598))
* **portal:** show PO pay button if payments installed ([cea4ed6](cea4ed6))
* Pricing rule application/removal on qty change ([#39084](#39084)) ([f310707](f310707))
* production plan date filters for orders (backport [#39702](#39702)) ([#39720](#39720)) ([3eac436](3eac436))
* remove applied pricing rule on qty change (backport [#39688](#39688)) ([#39737](#39737)) ([f246684](f246684))
* remove file from the disk after the completion of reposting ([b582e9c](b582e9c))
* show warehouse title field in sales docs (backport [#39746](#39746)) ([#39755](#39755)) ([53992de](53992de))
* update company in serial no doc (backport [#39733](#39733)) ([#39747](#39747)) ([00e86bf](00e86bf))
* use old serial / batch fields to make serial batch bundle ([282c19e](282c19e))
* **work order:** resolve type error during job card creation (backport [#39713](#39713)) ([#39714](#39714)) ([5fe40ac](5fe40ac))

### Features

* copy emails from lead to customer ([#38647](#38647)) ([986273b](986273b))
* make material request for job card from workstation dashboard ([3bef12c](3bef12c))
* Period-wise closing entries for TB ([#39712](#39712)) ([1822325](1822325))
* reference for POS SI payments ([#39523](#39523)) ([4ee8cf3](4ee8cf3))
* visual plant floor ([75bd1e6](75bd1e6))

### Performance Improvements

* memory consumption for the stock balance report ([#39626](#39626)) ([5e29aab](5e29aab))
* Move dimension validation out of GL Entry doctype ([#39730](#39730)) ([451c288](451c288))
* timeout for auto material request through reorder level ([1b2831b](1b2831b))
* timeout while submitting the purchase receipt entry ([55a8326](55a8326))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-aga-r s-aga-r s-aga-r approved these changes

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In Production Plan - Sales order filter is not working
2 participants
@GursheenK @s-aga-r