-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat add loader for gltf subasset #1071 #1075
Conversation
fix: wrong word recieveShadow to receiveShadow
* support gltF materials remap
Codecov ReportBase: 44.24% // Head: 41.89% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev/0.9 #1075 +/- ##
===========================================
- Coverage 44.24% 41.89% -2.35%
===========================================
Files 342 343 +1
Lines 17837 17947 +110
Branches 2459 2491 +32
===========================================
- Hits 7892 7519 -373
- Misses 9295 9825 +530
+ Partials 650 603 -47
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
* fix: material resolved with Texture References
Sub asset parser should use sub asset loader. You use the cache of parser result if you have loaded the sub asset. Such as: for(let i = 0;i < textures.length: i++) {
contex.textures[i] = resourceManager.load(context.url + `q=textures[${i}]`);
} |
# Conflicts: # packages/core/src/shadow/Extension.ts # packages/core/src/shadow/ShadowFeature.ts # packages/loader/src/GLTFLoader.ts # packages/loader/src/gltf/GLTFParser.ts # packages/loader/src/gltf/GLTFResource.ts # packages/loader/src/gltf/parser/AnimationParser.ts # packages/loader/src/gltf/parser/MaterialParser.ts # packages/loader/src/gltf/parser/MeshParser.ts # packages/loader/src/gltf/parser/Parser.ts # packages/loader/src/gltf/parser/SceneParser.ts # packages/loader/src/gltf/parser/TextureParser.ts
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: