Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix url clamp bug #1860

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Fix url clamp bug #1860

merged 4 commits into from
Nov 6, 2023

Conversation

gz65555
Copy link
Collaborator

@gz65555 gz65555 commented Nov 2, 2023

Fix #1653

@gz65555 gz65555 requested a review from GuoLei1990 November 2, 2023 09:33
@GuoLei1990 GuoLei1990 added the Bug Something isn't working label Nov 6, 2023
@GuoLei1990 GuoLei1990 marked this pull request as draft November 6, 2023 02:51
@codecov Codecov
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (948aaa1) 67.02% compared to head (3c9e75b) 67.02%.
Report is 2 commits behind head on main.

❗ Current head 3c9e75b differs from pull request most recent head 46d14cf. Consider uploading reports for the commit 46d14cf to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1860   +/-   ##
=======================================
  Coverage   67.02%   67.02%           
=======================================
  Files         471      471           
  Lines       23741    23742    +1     
  Branches     3379     3381    +2     
=======================================
+ Hits        15912    15914    +2     
- Misses       6625     6630    +5     
+ Partials     1204     1198    -6
Files Coverage Δ
packages/shader-lab/src/Ast2GLSLUtils.ts 66.66% <100.00%> (+9.52%) ⬆️
packages/core/src/asset/ResourceManager.ts 61.35% <83.33%> (+1.25%) ⬆️
packages/shader-lab/src/ast-node/AstNode.ts 81.12% <40.00%> (-0.59%) ⬇️
...e-deserialize/resources/parser/ReflectionParser.ts 12.12% <12.50%> (-0.79%) ⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 marked this pull request as ready for review November 6, 2023 06:00
@GuoLei1990 GuoLei1990 changed the title Fix url clamp Fix url clamp bug Nov 6, 2023
@GuoLei1990 GuoLei1990 added resource Resource-related functions loader and removed resource Resource-related functions labels Nov 6, 2023
@GuoLei1990 GuoLei1990 merged commit 7a7bc45 into galacean:main Nov 6, 2023
GuoLei1990 added a commit that referenced this pull request Nov 13, 2023
@GuoLei1990
Merge branch 'main' into dev/1.2
d233eef 
* main:
  fix: material destroy bug (#1864)
  Fix asset promise (#1867)
  Set `SpriteMask.sprite` to null after destroying the sprite.  (#1866)
  "v1.1.0-beta.19"
  Add recursive class and methods (#1865)
  Fix url clamp bug (#1860)
  feat: add recursive object parse (#1863)
  Fix ShaderLab compatible with no varying variable (#1859)
  Fix ShaderLab umd package compilation and circle reference (#1856)
  Add unit test case of `ColliderShape` (#1740)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuoLei1990 GuoLei1990 GuoLei1990 approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working loader
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2D纹理加载，url参数被截取掉了
2 participants
@gz65555 @GuoLei1990