Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sky material destroy bug #1864

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

zhuxudong
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Fix #2055

@zhuxudong zhuxudong added the Bug Something isn't working label Nov 6, 2023
@zhuxudong zhuxudong requested a review from GuoLei1990 November 6, 2023 06:48
@zhuxudong zhuxudong self-assigned this Nov 6, 2023
@zhuxudong zhuxudong changed the title Fix material destoroy bug Fix sky material destroy bug Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (7a7bc45) 67.01% compared to head (5c811f1) 67.02%.

❗ Current head 5c811f1 differs from pull request most recent head 6a9408b. Consider uploading reports for the commit 6a9408b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1864   +/-   ##
=======================================
  Coverage   67.01%   67.02%           
=======================================
  Files         471      471           
  Lines       23742    23753   +11     
  Branches     3381     3384    +3     
=======================================
+ Hits        15911    15920    +9     
- Misses       6633     6635    +2     
  Partials     1198     1198           
Files Coverage Δ
packages/core/src/mesh/MeshRenderer.ts 80.68% <0.00%> (-2.85%) ⬇️
packages/core/src/shader/ShaderProgram.ts 61.72% <0.00%> (-0.52%) ⬇️
packages/core/src/sky/Sky.ts 20.37% <0.00%> (-2.55%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cptbtptpbcptdtptp
Copy link
Collaborator

@zhuxudong 我之前也遇到了类似的问题
#1852
不过这块 @GuoLei1990 说应该整体设计一下,走一套方案。
#1858

@GuoLei1990 GuoLei1990 merged commit c8cad90 into galacean:main Nov 10, 2023
GuoLei1990 added a commit that referenced this pull request Nov 13, 2023
* main:
  fix: material destroy bug (#1864)
  Fix asset promise (#1867)
  Set `SpriteMask.sprite` to null after destroying the sprite.  (#1866)
  "v1.1.0-beta.19"
  Add recursive class and methods (#1865)
  Fix url clamp bug (#1860)
  feat: add recursive object parse (#1863)
  Fix ShaderLab compatible with no varying variable (#1859)
  Fix ShaderLab umd package compilation and circle reference (#1856)
  Add unit test case of `ColliderShape` (#1740)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants