Camera support opaque texture #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuoLei1990
added
enhancement
* dev/1.2: (29 commits) Add `Preprocessor` in `ShaderLab` (galacean#2009) "v1.2.0-alpha.11" Add ShaderLab package umd entry (galacean#2006) Fix primitive e2e error (galacean#2007) "v1.2.0-alpha.10" "v1.1.0-beta.49" "v1.1.0-beta.48" Physics raycast hitResult add shape (galacean#2004) Fix output glsl error when `function overload` exists in shaderlab source code (galacean#2001) refactor: adapter shadowFadeBorder exported from editor (galacean#1999) refactor(render-sort-compare): opt compare code (galacean#2002) feat: modify the method of generating the path (galacean#2000) "v1.1.0-beta.47" Fix`gl.MIN` and `gl.MAX` doesn't exist in `webgl1` (galacean#1990) Fix glb/gltf use extension parse (galacean#1992) "v1.1.0-beta.46" Fix query path error (galacean#1986) "v1.1.0-beta.45" "v1.1.0-beta.44" Fix the problem of resetting `HtmlCanvas.ClientXXX` when call `canvas.resizeByClientSize()` (galacean#1984) ...
* dev/1.2: Fix animation error (galacean#2014) Fix camera renderTarget flip error (galacean#1997)
zhuxudong
reviewed
Feb 28, 2024
| // Check if need to create internal color texture | ||
| const independentCanvasEnabled = camera.independentCanvasEnabled; | ||
| if (independentCanvasEnabled && Vector4.equals(camera.viewport, PipelineUtils.defaultViewport)) { | ||
| console.warn( |
zhuxudong
reviewed
Feb 28, 2024
zhuxudong
reviewed
Feb 28, 2024
zhuxudong
reviewed
Feb 28, 2024
zhuxudong
reviewed
Feb 28, 2024
zhuxudong
reviewed
Feb 28, 2024
| } else { | ||
| const internalColorTarget = this._internalColorTarget; | ||
| if (internalColorTarget) { | ||
| internalColorTarget.destroy(); |
There was a problem hiding this comment.
will gc crash when switch renderTarget and open opaqueTextureEnabled
|
do we should flip viewport when context.flipProjection is true ? Has BUG |
zhuxudong
reviewed
Feb 28, 2024
Yes,has BUG!!! Fixed!!! |
|
|
zhuxudong
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Major changes:
opaqueTextureEnabledandopaqueTextureDownsamplingindependentCanvasEnabled, enable this can on/off MSAA per camera bymsaaSamples(opaqueTextureEnabled force turn on this mode)BasicResourcesclass to store internal resource_setRenderTargetInfoto simplify the logicTODO:
Future: