Missing downloads, sha256sum, broken URLs #213
Conversation
Additionally whitespace changes were applied unintentionally thanks to python/xml.etree
Merged in @yhoogstrate's work
|
Go for it @erasche looks good to me! |
|
Sorry, should've been marked as WIP. We still need to check all the URLs, either @yhoogstrate has made progress on testing installation for every package, or I will tomorrow hopefully with the jenkins bot |
hexylena
changed the title
|
@erasche I can't figure out how to use planemo (shed_test?), to only check whether installation via tool_dependencies.xml fail or not. |
|
Working on this now :) tor. 30. jul. 2015 kl. 06.46 skrev yhoogstrate notifications@github.com:
|
|
@erasche Can we close this PR since you've been working on an alternative solution? |
|
@yhoogstrate let's leave it open. The alternate solution will still need your sha256sums that you contributed in this PR, they'll just have different URLs. I'll get the URLs updated in this PR soon. |
|
Who can we sacrifice to manually test each package? 😈 |
|
Yikes, yeah. I'd like to see the ruby ones tested specifically since I had to change the |
| <tool_dependency> | ||
| <package name="Fido" version="f63cd47b8414f87d57b8c1b713d34a04b29c7aee"> | ||
| <install version="1.0"> | ||
| <actions> | ||
| <actions> | ||
| <action type="shell_command">git clone --recursive https://github.com/hendrikweisser/Fido.git</action> |
There was a problem hiding this comment.
This repo contains no submodules so a recursive clone shouldn't be necessary. Maybe we can change it to using githubs revision specific /archive/-url like this: https://github.com/galaxyproject/tools-iuc/blob/master/test_repositories/golang_package/tool_dependencies.xml#L9
This is uglier than a rebase, but a LOT simpler
hexylena
changed the title
|
Rebased, out of WIP :) |
|
👏 |
| @@ -3,7 +3,9 @@ | |||
| <package name="bedtools" version="2.22"> | |||
| <install version="1.0"> | |||
| <actions> | |||
| <action type="download_by_url">https://github.com/arq5x/bedtools2/releases/download/v2.22.1/bedtools-2.22.1.tar.gz</action> | |||
| <action type="download_by_url" sha256sum="43ab5da6b41350bbef78ea2ee5be0609fb02d76b920a3301b687a39af7017233"> | |||
| https://depot.galaxyproject.org/software/bedtools/bedtools_2.22_src_all.tar.gz | |||
There was a problem hiding this comment.
This downloads version 2.22 and not 2.22.1
There was a problem hiding this comment.
| <!-- first action is always downloading --> | ||
| <action type="download_by_url" target_filename="matplotlib-1.2.1.tar.gz">https://github.com/matplotlib/matplotlib/archive/v1.2.1.tar.gz#md5#47ee56f51200b8760b98d97ee86f57c6</action> | ||
|
|
||
| <action type="download_by_url" sha256sum="52e18972aed85f30b05cef41778ec77685df6012f0598cd216e996de9b9ea29b"> |
There was a problem hiding this comment.
Updated against master so this PR is merge-able
Really sorry not to be rebasing these but you have to work through the entire history, picking out the correct changes each time, it's an absolute nightmare :(
|
I am gonna merge this today unless someone screams |
Missing downloads, sha256sum, broken URLs
|
merged, thanks a bunch @erasche ! |
|
Don't forget @yhoogstrate! |
|
Youri thanks! @yhoogstrate |
|
The changes from this PR did not make it to the MTS since it predates travis deployment. Any good way how to make travis update all of these? @erasche @yhoogstrate @bgruening @nsoranzo ? |
|
Packages are deprecated in tools-iuc, we can update a repo on the MTS when someone complains about it. |
|
@nsoranzo good point, you are absolutely right |
No description provided.