Revised "winning over engineering leaders" Docs page #14830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caitlinthefirst
added
the
type: documentation
gillkyle
reviewed
Jun 17, 2019
There was a problem hiding this comment.
This is looking awesome, thanks so much for jumping on these @caitlinthefirst!
I left a couple suggestions but I think your writing is awesome 🙌
One other thing I noticed is that the stub can be removed in the sidebar
gatsby/www/src/data/sidebars/doc-links.yaml
Line 472 in 0c0e316
Typo in "Scalability" section. Co-Authored-By: gillkyle <kylerobertgill@gmail.com>
Co-Authored-By: gillkyle <kylerobertgill@gmail.com>
…over-engineering-leaders.md Co-Authored-By: gillkyle <kylerobertgill@gmail.com>
Co-Authored-By: gillkyle <kylerobertgill@gmail.com>
|
Thanks for the edits, @gillkyle! They've been committed. |
|
@caitlinthefirst you're making updates faster than I can keep up! Amazing! 😄 |
|
Lol! Well, I ended up just merging your suggestions. They looked good to me. |
marcysutton
suggested changes
Jun 17, 2019
There was a problem hiding this comment.
This is fantastic. Thanks so much for working on it, @caitlinthefirst! I left a few suggestions, overall this is in great shape.
Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
marcysutton
approved these changes
Jun 18, 2019
There was a problem hiding this comment.
This is awesome. Thanks so much for the contribution, @caitlinthefirst !
m-allanson
added a commit
that referenced
this pull request
Jun 19, 2019
* master: (41 commits) chore(release): Publish fix(gatsby): Normalize paths for run queries before caching (#14910) chore(release): Publish fix(gatsby-cli): add missing node-fetch dependency (#14908) feat(blog): Site Showcase Validator blogpost (#14855) chore(gatsby-remark-graphviz): add --ignore for test directory (#14906) fix(tutorials): rename "advanced" to "additional (#14847) fix(starters): update gatsby monorepo (#14886) chore(starters): Switch to useStaticQuery (#14857) chore(release): Publish Add status bar to bottom of screen during develop (#14874) chore(release): Publish fix(*): fix gatsby-cli dep in source-filesystem & plugin-sharp (#14881) docs(www): 25 Workflows - Embedding components in Markdown with MDX (#14543) docs(blog): add case study blog post for The Couch / Prima (#14871) docs(www): 25 Workflows - Adding CSS and/or Sass (#14779) fix(gatsby-transformer-react-docgen): always create description nodes (#14876) chore(release): Publish chore(gatsby): revert progressbar functionality (#14884) Revised "winning over engineering leaders" Docs page (#14830) ...
mxxk
pushed a commit
to mxxk/gatsby
that referenced
this pull request
Jun 21, 2019
* Revised "winning over engineering leaders" Docs page * Correction made to first "concern" bullet. * Fix typo in docs/docs/winning-over-engineering-leaders.md Typo in "Scalability" section. Co-Authored-By: gillkyle <kylerobertgill@gmail.com> * Update docs/docs/winning-over-engineering-leaders.md Co-Authored-By: gillkyle <kylerobertgill@gmail.com> * Edit "static site" language in Security section of docs/docs/winning-over-engineering-leaders.md Co-Authored-By: gillkyle <kylerobertgill@gmail.com> * Update docs/docs/winning-over-engineering-leaders.md Co-Authored-By: gillkyle <kylerobertgill@gmail.com> * chore: format * Update winning-over-engineering-leaders.md * Apply Marcy's suggestions from code review Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com> * Additional revision based on Marcy's suggestions.
johno
pushed a commit
to johno/gatsby
that referenced
this pull request
Jul 17, 2019
* Revised "winning over engineering leaders" Docs page * Correction made to first "concern" bullet. * Fix typo in docs/docs/winning-over-engineering-leaders.md Typo in "Scalability" section. Co-Authored-By: gillkyle <kylerobertgill@gmail.com> * Update docs/docs/winning-over-engineering-leaders.md Co-Authored-By: gillkyle <kylerobertgill@gmail.com> * Edit "static site" language in Security section of docs/docs/winning-over-engineering-leaders.md Co-Authored-By: gillkyle <kylerobertgill@gmail.com> * Update docs/docs/winning-over-engineering-leaders.md Co-Authored-By: gillkyle <kylerobertgill@gmail.com> * chore: format * Update winning-over-engineering-leaders.md * Apply Marcy's suggestions from code review Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com> * Additional revision based on Marcy's suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've drafted a "Winning Over Engineering Leaders" stakeholder page to replace the current stub. This follows the format present on the "Winning Over Marketers" and "... Developers" pages. Please let me know if I've missed the mark or need any edits.
Related Issues
Partially addresses #14040. Pull request for Executive stakeholder stub will follow by 6/18/19.