Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby-remark-graphviz): add --ignore for test directory #14906

Merged
merged 1 commit into from
Jun 19, 2019

Conversation

wardpeet
Copy link
Contributor

Description

Ignores the test directory when building gatsby-remark-graphviz. Whenever you run yarn bootstrap you get an untracked file.

image

@wardpeet wardpeet requested a review from a team as a code owner June 19, 2019 12:08
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I saw this yesterday as well! Thank you for fixing 🥇

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jun 19, 2019
@gatsbybot gatsbybot merged commit 2dc899f into gatsbyjs:master Jun 19, 2019
@sidharthachatterjee
Copy link
Contributor

Published in gatsby-remark-graphviz@1.0.13

m-allanson added a commit that referenced this pull request Jun 19, 2019
* master: (41 commits)
  chore(release): Publish
  fix(gatsby): Normalize paths for run queries before caching (#14910)
  chore(release): Publish
  fix(gatsby-cli): add missing node-fetch dependency (#14908)
  feat(blog): Site Showcase Validator blogpost (#14855)
  chore(gatsby-remark-graphviz): add --ignore for test directory (#14906)
  fix(tutorials): rename "advanced" to "additional (#14847)
  fix(starters): update gatsby monorepo (#14886)
  chore(starters): Switch to useStaticQuery (#14857)
  chore(release): Publish
  Add status bar to bottom of screen during develop (#14874)
  chore(release): Publish
  fix(*): fix gatsby-cli dep in source-filesystem & plugin-sharp (#14881)
  docs(www): 25 Workflows - Embedding components in Markdown with MDX (#14543)
  docs(blog): add case study blog post for The Couch / Prima (#14871)
  docs(www): 25 Workflows - Adding CSS and/or Sass (#14779)
  fix(gatsby-transformer-react-docgen): always create description nodes (#14876)
  chore(release): Publish
  chore(gatsby): revert progressbar functionality (#14884)
  Revised "winning over engineering leaders" Docs page (#14830)
  ...
@wardpeet wardpeet deleted the fix/remark-graphviz-test branch September 23, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants