Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tutorials): rename "advanced" to "additional #14847

Merged
merged 2 commits into from
Jun 19, 2019
Merged

Conversation

marcysutton
Copy link
Contributor

@marcysutton marcysutton commented Jun 17, 2019

As an outcome of the Tutorials planning meeting with @amberleyromo, this PR gives us room to add step-by-step content that isn't necessarily advanced in nature. This is intended to be an interim measure ahead of the big Tutorials overhaul where the step-by-step learning approach will evolve completely.

Future changes we anticipate after this PR:

  • Additional Tutorials could have topical groupings added to it, such as "Working with Wordpress" or "e-commerce tutorials"
  • Until we fully think through a Building for Gatsby section, Additional Tutorials could link off to plugin/theme authoring tutorials in the docs. (i.e. "Looking to build Gatsby themes or plugins? Check out the docs")

This gives us room to add step-by-step content that isn't necessarily advanced in nature ahead of the big Tutorials overhaul
@marcysutton marcysutton requested a review from a team June 17, 2019 21:20
@marcysutton marcysutton requested a review from a team as a code owner June 17, 2019 21:20
wardpeet
wardpeet previously approved these changes Jun 18, 2019
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a small comment about the redirects. That's everything I can come up with besides Aweomse job! 👏

www/gatsby-node.js Show resolved Hide resolved
@wardpeet wardpeet dismissed their stale review June 18, 2019 07:17

wrong button

Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed a duplicate redirect but looking great! Thank you @marcysutton and @amberleyromo for your commitment to making our language more accessible! ❤️

www/gatsby-node.js Outdated Show resolved Hide resolved
Co-Authored-By: Sidhartha Chatterjee <me@sidharthachatterjee.com>
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in! 🙌

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jun 19, 2019
@gatsbybot gatsbybot merged commit fb49cd9 into master Jun 19, 2019
@sidharthachatterjee sidharthachatterjee deleted the additional-tutorials branch June 19, 2019 12:01
m-allanson added a commit that referenced this pull request Jun 19, 2019
* master: (41 commits)
  chore(release): Publish
  fix(gatsby): Normalize paths for run queries before caching (#14910)
  chore(release): Publish
  fix(gatsby-cli): add missing node-fetch dependency (#14908)
  feat(blog): Site Showcase Validator blogpost (#14855)
  chore(gatsby-remark-graphviz): add --ignore for test directory (#14906)
  fix(tutorials): rename "advanced" to "additional (#14847)
  fix(starters): update gatsby monorepo (#14886)
  chore(starters): Switch to useStaticQuery (#14857)
  chore(release): Publish
  Add status bar to bottom of screen during develop (#14874)
  chore(release): Publish
  fix(*): fix gatsby-cli dep in source-filesystem & plugin-sharp (#14881)
  docs(www): 25 Workflows - Embedding components in Markdown with MDX (#14543)
  docs(blog): add case study blog post for The Couch / Prima (#14871)
  docs(www): 25 Workflows - Adding CSS and/or Sass (#14779)
  fix(gatsby-transformer-react-docgen): always create description nodes (#14876)
  chore(release): Publish
  chore(gatsby): revert progressbar functionality (#14884)
  Revised "winning over engineering leaders" Docs page (#14830)
  ...
mxxk pushed a commit to mxxk/gatsby that referenced this pull request Jun 21, 2019
* fix(tutorials): advanced -> additional

This gives us room to add step-by-step content that isn't necessarily advanced in nature ahead of the big Tutorials overhaul

* Update www/gatsby-node.js

Co-Authored-By: Sidhartha Chatterjee <me@sidharthachatterjee.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants