Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): add Clodui deployment guide #23587

Merged
merged 7 commits into from
May 11, 2020
Merged

chore(docs): add Clodui deployment guide #23587

merged 7 commits into from
May 11, 2020

Conversation

cvrajeesh
Copy link
Contributor

Description

This PR adds a guide to deploying a Gatsby website to Clodui

@cvrajeesh cvrajeesh requested review from a team as code owners April 29, 2020 10:37
@Ekwuno Ekwuno added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Apr 29, 2020
Ekwuno
Ekwuno suggested changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@Ekwuno Ekwuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this in. I have done the first sweep and left a few suggestions. I would also suggest that steps be followed up by code blocks to make the process clearer

docs/docs/deploying-to-clodui.md Outdated Show resolved Hide resolved
docs/docs/deploying-to-clodui.md Outdated Show resolved Hide resolved
docs/docs/deploying-to-clodui.md Show resolved Hide resolved
docs/docs/deploying-to-clodui.md Outdated Show resolved Hide resolved
docs/docs/deploying-to-clodui.md Outdated Show resolved Hide resolved
docs/docs/deploying-to-clodui.md Show resolved Hide resolved
docs/docs/deploying-to-clodui.md Outdated Show resolved Hide resolved
docs/docs/deploying-to-clodui.md Outdated Show resolved Hide resolved
docs/docs/deploying-to-clodui.md Outdated Show resolved Hide resolved
@cvrajeesh
Copy link
Contributor Author

@Ekwuno updated PR with suggested changes

cvrajeesh
cvrajeesh commented May 1, 2020
View reviewed changes
Copy link
Contributor Author

@cvrajeesh cvrajeesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated PR with requested changes

cvrajeesh
cvrajeesh commented May 3, 2020
View reviewed changes
Copy link
Contributor Author

@cvrajeesh cvrajeesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes done

@cvrajeesh cvrajeesh requested a review from Ekwuno May 7, 2020 10:52
@cvrajeesh
Copy link
Contributor Author

Hi @Ekwuno,

I've made the changes you've requested, could you please review it and let me know if there are any more changes required.

Ekwuno
Ekwuno reviewed May 11, 2020
View reviewed changes
docs/docs/deploying-to-clodui.md Outdated Show resolved Hide resolved
docs/docs/deploying-to-clodui.md Outdated Show resolved Hide resolved
Ekwuno
Ekwuno approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@Ekwuno Ekwuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologise for missing this. I have looked through and made some changes. Thanks for your patience with me and your contribution to Gatsby 💜.

@Ekwuno Ekwuno merged commit c5144ea into gatsbyjs:master May 11, 2020
@gatsbot
Copy link

gatsbot bot commented May 11, 2020

Holy buckets, @cvrajeesh — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@cvrajeesh cvrajeesh deleted the docs/clodui-deployment-guide branch May 11, 2020 13:30
KyleAMathews added a commit that referenced this pull request May 13, 2020
@KyleAMathews
Squashed commit of the following:
1c153a0 
commit 9bd54be
Author: Hashim Warren <hashim@gatsbyjs.com>
Date:   Mon May 11 16:31:31 2020 -0400

    (chore)Update Incremental Builds blog post with list (#23981)

    * Update steps with ordered list

    * Update docs/blog/2020-04-22-announcing-incremental-builds/index.md

    Co-authored-by: Matt Kane <matt@gatsbyjs.com>

    * Update docs/blog/2020-04-22-announcing-incremental-builds/index.md

    Co-authored-by: Matt Kane <matt@gatsbyjs.com>

    * Update link and SEO title

    * chore: format

    Co-authored-by: Matt Kane <matt@gatsbyjs.com>
    Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>

commit e8b6eea
Author: shannonbux <32467162+shannonbux@users.noreply.github.com>
Date:   Mon May 11 10:37:30 2020 -0700

    fixed capitalization

commit f457912
Author: Diogo Capela <diogocapela@gmail.com>
Date:   Mon May 11 18:04:08 2020 +0100

    chore(showcase): Add Zona Digital to Gatsby Showcase (#23980)

    Co-authored-by: Capela <diogo.capela@mindera.com>
    Co-authored-by: Matt Kane <matt@gatsbyjs.com>

commit eb0f0d8
Author: Mike Dane <mikedane94@gmail.com>
Date:   Tue May 12 02:42:34 2020 +1000

    removed space on bootstrap finished time (#23925)

    Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>

commit c7e952b
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Mon May 11 17:39:08 2020 +0100

    chore: update www (#23971)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>

commit 224e84e
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Mon May 11 17:38:30 2020 +0100

    fix: update starters and examples (#23972)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>

commit 7b74535
Author: Raz Lifshitz <30860151+razrez@users.noreply.github.com>
Date:   Mon May 11 19:13:43 2020 +0300

    Update sites.yml (#23938)

    * Update sites.yml

    Added ofrilifshitz.com to sites.yml

    * chore: format

    Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>

commit e5a2461
Author: Matt Kane <matt@gatsbyjs.com>
Date:   Mon May 11 17:11:20 2020 +0100

    Add redirect for Vercel docs (#23979)

commit 441f32a
Author: Christian Rackerseder <git@echooff.de>
Date:   Mon May 11 17:27:38 2020 +0200

    Rename ZEIT Now to Vercel (#23961)

commit 7a23392
Author: Dede Hamzah <dehamzah@users.noreply.github.com>
Date:   Mon May 11 21:45:23 2020 +0700

    fix: handle nullish announcementRef to fix client side redirect error (#23956)

commit 49dfc6f
Author: Gabriel Ramos <gabriel.luiz.ramos@gmail.com>
Date:   Mon May 11 10:42:17 2020 -0300

    chore(gatsby): Convert jobsV2 reducer to TS (#23708)

    * chore(ts): convert jobsv2 reducer to TS

    * Update packages/gatsby/src/redux/reducers/jobsv2.ts

    Co-authored-by: Ward Peeters <ward@coding-tech.com>

    * refactor(pr): refactor based on PR comments

    * Update packages/gatsby/src/redux/reducers/jobsv2.ts

    Co-authored-by: Ward Peeters <ward@coding-tech.com>

    * fix(lint): fix lint error

    * add result typing to jobs-manager

    Co-authored-by: Ward Peeters <ward@coding-tech.com>

commit c5144ea
Author: Rajeesh C V <cvrajeesh@gmail.com>
Date:   Mon May 11 18:53:21 2020 +0530

    chore(docs): add Clodui deployment guide (#23587)

    * chore(docs): add Clodui deployment guide

    * update Clodui deployment doc with review comments

    * Update docs/docs/deploying-to-clodui.md

    * Update docs/docs/deploying-to-clodui.md

    * Update docs/docs/deploying-to-clodui.md

    * Update docs/docs/deploying-to-clodui.md

    * chore: format

    Co-authored-by: Obinna Ekwuno <obinnacodes@gmail.com>
    Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>

commit c34bd66
Author: Michal Piechowiak <misiek.piechowiak@gmail.com>
Date:   Mon May 11 12:54:24 2020 +0200

    chore(release): Publish

     - gatsby-admin@0.1.22
     - gatsby-cli@2.12.16
     - gatsby-recipes@0.1.15
     - gatsby-theme-blog-core@1.4.22
     - gatsby-theme-blog@1.5.22
     - gatsby-theme-notes@1.3.22
     - gatsby-theme-ui-preset@0.0.12
     - gatsby@2.21.22

commit f7dc43f
Author: Albert Lash <31164347+albertlincoln@users.noreply.github.com>
Date:   Mon May 11 11:52:59 2020 +0100

    fix(gatsby-cli): don't fail when using `--log-pages` and/or `--write-to-file` (#23951)

    * Adding new cli options for page optimization

    * prettier

    * make them hidden, add some description as well as comment about why they are hidden

    Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>

commit 88056f0
Author: Michal Piechowiak <misiek.piechowiak@gmail.com>
Date:   Mon May 11 01:17:47 2020 +0200

    fix(www): allow to tree shake lodash-es (#23967)

commit e267ca0
Author: Andrés Bedoya <Angelfire@users.noreply.github.com>
Date:   Sat May 9 15:51:42 2020 -0500

    Update deploying-to-zeit-now.md (#23946)
gatsbybot pushed a commit that referenced this pull request May 13, 2020
@KyleAMathews
fix(gatsby-recipes): support code blocks on cli (#23996)
6a322dc 
* fix(gatsby-recipes): support code blocks on cli

* Squashed commit of the following:

commit 9bd54be
Author: Hashim Warren <hashim@gatsbyjs.com>
Date:   Mon May 11 16:31:31 2020 -0400

    (chore)Update Incremental Builds blog post with list (#23981)

    * Update steps with ordered list

    * Update docs/blog/2020-04-22-announcing-incremental-builds/index.md

    Co-authored-by: Matt Kane <matt@gatsbyjs.com>

    * Update docs/blog/2020-04-22-announcing-incremental-builds/index.md

    Co-authored-by: Matt Kane <matt@gatsbyjs.com>

    * Update link and SEO title

    * chore: format

    Co-authored-by: Matt Kane <matt@gatsbyjs.com>
    Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>

commit e8b6eea
Author: shannonbux <32467162+shannonbux@users.noreply.github.com>
Date:   Mon May 11 10:37:30 2020 -0700

    fixed capitalization

commit f457912
Author: Diogo Capela <diogocapela@gmail.com>
Date:   Mon May 11 18:04:08 2020 +0100

    chore(showcase): Add Zona Digital to Gatsby Showcase (#23980)

    Co-authored-by: Capela <diogo.capela@mindera.com>
    Co-authored-by: Matt Kane <matt@gatsbyjs.com>

commit eb0f0d8
Author: Mike Dane <mikedane94@gmail.com>
Date:   Tue May 12 02:42:34 2020 +1000

    removed space on bootstrap finished time (#23925)

    Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>

commit c7e952b
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Mon May 11 17:39:08 2020 +0100

    chore: update www (#23971)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>

commit 224e84e
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Mon May 11 17:38:30 2020 +0100

    fix: update starters and examples (#23972)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>

commit 7b74535
Author: Raz Lifshitz <30860151+razrez@users.noreply.github.com>
Date:   Mon May 11 19:13:43 2020 +0300

    Update sites.yml (#23938)

    * Update sites.yml

    Added ofrilifshitz.com to sites.yml

    * chore: format

    Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>

commit e5a2461
Author: Matt Kane <matt@gatsbyjs.com>
Date:   Mon May 11 17:11:20 2020 +0100

    Add redirect for Vercel docs (#23979)

commit 441f32a
Author: Christian Rackerseder <git@echooff.de>
Date:   Mon May 11 17:27:38 2020 +0200

    Rename ZEIT Now to Vercel (#23961)

commit 7a23392
Author: Dede Hamzah <dehamzah@users.noreply.github.com>
Date:   Mon May 11 21:45:23 2020 +0700

    fix: handle nullish announcementRef to fix client side redirect error (#23956)

commit 49dfc6f
Author: Gabriel Ramos <gabriel.luiz.ramos@gmail.com>
Date:   Mon May 11 10:42:17 2020 -0300

    chore(gatsby): Convert jobsV2 reducer to TS (#23708)

    * chore(ts): convert jobsv2 reducer to TS

    * Update packages/gatsby/src/redux/reducers/jobsv2.ts

    Co-authored-by: Ward Peeters <ward@coding-tech.com>

    * refactor(pr): refactor based on PR comments

    * Update packages/gatsby/src/redux/reducers/jobsv2.ts

    Co-authored-by: Ward Peeters <ward@coding-tech.com>

    * fix(lint): fix lint error

    * add result typing to jobs-manager

    Co-authored-by: Ward Peeters <ward@coding-tech.com>

commit c5144ea
Author: Rajeesh C V <cvrajeesh@gmail.com>
Date:   Mon May 11 18:53:21 2020 +0530

    chore(docs): add Clodui deployment guide (#23587)

    * chore(docs): add Clodui deployment guide

    * update Clodui deployment doc with review comments

    * Update docs/docs/deploying-to-clodui.md

    * Update docs/docs/deploying-to-clodui.md

    * Update docs/docs/deploying-to-clodui.md

    * Update docs/docs/deploying-to-clodui.md

    * chore: format

    Co-authored-by: Obinna Ekwuno <obinnacodes@gmail.com>
    Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>

commit c34bd66
Author: Michal Piechowiak <misiek.piechowiak@gmail.com>
Date:   Mon May 11 12:54:24 2020 +0200

    chore(release): Publish

     - gatsby-admin@0.1.22
     - gatsby-cli@2.12.16
     - gatsby-recipes@0.1.15
     - gatsby-theme-blog-core@1.4.22
     - gatsby-theme-blog@1.5.22
     - gatsby-theme-notes@1.3.22
     - gatsby-theme-ui-preset@0.0.12
     - gatsby@2.21.22

commit f7dc43f
Author: Albert Lash <31164347+albertlincoln@users.noreply.github.com>
Date:   Mon May 11 11:52:59 2020 +0100

    fix(gatsby-cli): don't fail when using `--log-pages` and/or `--write-to-file` (#23951)

    * Adding new cli options for page optimization

    * prettier

    * make them hidden, add some description as well as comment about why they are hidden

    Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>

commit 88056f0
Author: Michal Piechowiak <misiek.piechowiak@gmail.com>
Date:   Mon May 11 01:17:47 2020 +0200

    fix(www): allow to tree shake lodash-es (#23967)

commit e267ca0
Author: Andrés Bedoya <Angelfire@users.noreply.github.com>
Date:   Sat May 9 15:51:42 2020 -0500

    Update deploying-to-zeit-now.md (#23946)

* Add hicat to do syntax highlighting

* fix

* Fix

* Add hicat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ekwuno Ekwuno Ekwuno approved these changes

Assignees
No one assigned
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cvrajeesh @Ekwuno