chore(gatsby): Convert jobsV2 reducer to TS

[gabrieluizramos]

Description

In order to continue the conversion, this PR converts reducers/jobsv2 to TS.

Related Issues

Related to #21995

[ascorbic]

Thanks! Just a few changes related to behaviour when jobs aren't found.

[wardpeet]

What's the reason for these changes?

[gabrieluizramos]

I think that were some types that I didn't get right at the beggining, but now things are becoming more clear to me.

I'm removing the optional for the job, plugin, result and inputPaths keys inside this interface now. Since we actually set it inside the reducer we actually need the result and inputPaths in this interface. Am I right?

[wardpeet]

Sorry for not being super helpful before. Long day 😅.

You should make 2 types, 1 is the jobInput & the jobResult.

gatsby/packages/gatsby/src/utils/jobs-manager.js

Line 64 in 649b4dd

* @typedef {BaseJobInterface & JobInputInterface} JobInput

JobResult should be just an object, it could be anything but has to be an object.

gatsby/packages/gatsby/src/utils/jobs-manager.js

Line 255 in 649b4dd

* @return {Promise<object>}

[gabrieluizramos]

@wardpeet No worries! You guys are being super helpful actually!

But I think I didn't get it right yet...
The job input looks a little bit like the IGatsbyJobContent, are they the same?

Thought about updating it with a BaseJobInterface. The related types would be something like:

export interface IGatsbyJobContent {
  name: string
  outputDir: string
  args: Record<string, any>
  inputPaths: string[]
  contentDigest: string
  plugin: IGatsbyPlugin
}

export type IGatsbyJobResult = Promise<Record<string, any>>

export interface IGatsbyJobV2 {
  job: IGatsbyJobContent
  plugin: IGatsbyPlugin
  traceId?: string
  result: IGatsbyJobResult
  inputPaths: string[]
}

// and the actions

export interface ICreateJobV2Action {
  type: `CREATE_JOB_V2`
  payload: {
    job: IGatsbyJobV2["job"]
    plugin: IGatsbyJobV2["plugin"]
  }
}

export interface IEndJobV2Action {
  type: `END_JOB_V2`
  payload: {
    jobContentDigest: string
    result: IGatsbyJobResult
  }
}

export interface IRemoveStaleJobV2Action {
  type: `REMOVE_STALE_JOB_V2`
  payload: {
    contentDigest: string
  }
}

[wardpeet]

It seems like we have to do some cleanup here...

import { InternalJobInterface, JobResultInterface } from "../utils/jobs-manager"

export interface IGatsbyCreateJobV2 {
  job: InternalJobInterface
  plugin: IGatsbyPlugin
}
export interface IGatsbyCompleteJobV2 {
  result: JobResultInterface
  inputPaths: InternalJobInterface["inputPaths"]
}

jobsV2: {
  incomplete: Map<Identifier, IGatsbyCreateJobV2>
  complete: Map<Identifier, IGatsbyCompleteJobV2>
}

[gabrieluizramos]

@wardpeet Awesome! Thank you very much! I've already pushed the changes.

[wardpeet]

Awesome work! You're a beast!

[gabrieluizramos]

@wardpeet Thank you very much! You guys are awesome!!!

[gabrieluizramos]

Hi @ascorbic ! I think that maybe you still need to approve this PR. Can you help us?

ward is happy

[blainekasten]

This looks great to me, let's merge it!

Thank you so much for contributing to our TypeScript refactor! We have more work to do and we would love to have you stay involved in our transition. Please submit more PRs! 💜