Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-recipes): support code blocks on cli #23996

Merged
merged 7 commits into from
May 13, 2020
Merged

fix(gatsby-recipes): support code blocks on cli #23996

merged 7 commits into from
May 13, 2020

Conversation

KyleAMathews
Copy link
Contributor

@KyleAMathews KyleAMathews commented May 12, 2020 •
edited
Loading

Fixes #22991 (comment) cc @jsjoeio

Output
Screen Shot 2020-05-11 at 8 11 01 PM

Code
Screen Shot 2020-05-11 at 8 11 17 PM

Initial stab at this just renders the code blocks as exactly the same as the markdown. Is that... too on the nose?

Another option (not for tonight) is highlighting the code — https://github.com/rstacruz/hicat/blob/master/index.js

@KyleAMathews KyleAMathews requested a review from a team as a code owner May 12, 2020 03:16
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 12, 2020
@KyleAMathews KyleAMathews added topic: recipes and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 12, 2020
@KyleAMathews KyleAMathews self-assigned this May 12, 2020
@KyleAMathews
Squashed commit of the following:
1c153a0 
commit 9bd54be
Author: Hashim Warren <hashim@gatsbyjs.com>
Date:   Mon May 11 16:31:31 2020 -0400

    (chore)Update Incremental Builds blog post with list (#23981)

    * Update steps with ordered list

    * Update docs/blog/2020-04-22-announcing-incremental-builds/index.md

    Co-authored-by: Matt Kane <matt@gatsbyjs.com>

    * Update docs/blog/2020-04-22-announcing-incremental-builds/index.md

    Co-authored-by: Matt Kane <matt@gatsbyjs.com>

    * Update link and SEO title

    * chore: format

    Co-authored-by: Matt Kane <matt@gatsbyjs.com>
    Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>

commit e8b6eea
Author: shannonbux <32467162+shannonbux@users.noreply.github.com>
Date:   Mon May 11 10:37:30 2020 -0700

    fixed capitalization

commit f457912
Author: Diogo Capela <diogocapela@gmail.com>
Date:   Mon May 11 18:04:08 2020 +0100

    chore(showcase): Add Zona Digital to Gatsby Showcase (#23980)

    Co-authored-by: Capela <diogo.capela@mindera.com>
    Co-authored-by: Matt Kane <matt@gatsbyjs.com>

commit eb0f0d8
Author: Mike Dane <mikedane94@gmail.com>
Date:   Tue May 12 02:42:34 2020 +1000

    removed space on bootstrap finished time (#23925)

    Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>

commit c7e952b
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Mon May 11 17:39:08 2020 +0100

    chore: update www (#23971)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>

commit 224e84e
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Mon May 11 17:38:30 2020 +0100

    fix: update starters and examples (#23972)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>

commit 7b74535
Author: Raz Lifshitz <30860151+razrez@users.noreply.github.com>
Date:   Mon May 11 19:13:43 2020 +0300

    Update sites.yml (#23938)

    * Update sites.yml

    Added ofrilifshitz.com to sites.yml

    * chore: format

    Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>

commit e5a2461
Author: Matt Kane <matt@gatsbyjs.com>
Date:   Mon May 11 17:11:20 2020 +0100

    Add redirect for Vercel docs (#23979)

commit 441f32a
Author: Christian Rackerseder <git@echooff.de>
Date:   Mon May 11 17:27:38 2020 +0200

    Rename ZEIT Now to Vercel (#23961)

commit 7a23392
Author: Dede Hamzah <dehamzah@users.noreply.github.com>
Date:   Mon May 11 21:45:23 2020 +0700

    fix: handle nullish announcementRef to fix client side redirect error (#23956)

commit 49dfc6f
Author: Gabriel Ramos <gabriel.luiz.ramos@gmail.com>
Date:   Mon May 11 10:42:17 2020 -0300

    chore(gatsby): Convert jobsV2 reducer to TS (#23708)

    * chore(ts): convert jobsv2 reducer to TS

    * Update packages/gatsby/src/redux/reducers/jobsv2.ts

    Co-authored-by: Ward Peeters <ward@coding-tech.com>

    * refactor(pr): refactor based on PR comments

    * Update packages/gatsby/src/redux/reducers/jobsv2.ts

    Co-authored-by: Ward Peeters <ward@coding-tech.com>

    * fix(lint): fix lint error

    * add result typing to jobs-manager

    Co-authored-by: Ward Peeters <ward@coding-tech.com>

commit c5144ea
Author: Rajeesh C V <cvrajeesh@gmail.com>
Date:   Mon May 11 18:53:21 2020 +0530

    chore(docs): add Clodui deployment guide (#23587)

    * chore(docs): add Clodui deployment guide

    * update Clodui deployment doc with review comments

    * Update docs/docs/deploying-to-clodui.md

    * Update docs/docs/deploying-to-clodui.md

    * Update docs/docs/deploying-to-clodui.md

    * Update docs/docs/deploying-to-clodui.md

    * chore: format

    Co-authored-by: Obinna Ekwuno <obinnacodes@gmail.com>
    Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>

commit c34bd66
Author: Michal Piechowiak <misiek.piechowiak@gmail.com>
Date:   Mon May 11 12:54:24 2020 +0200

    chore(release): Publish

     - gatsby-admin@0.1.22
     - gatsby-cli@2.12.16
     - gatsby-recipes@0.1.15
     - gatsby-theme-blog-core@1.4.22
     - gatsby-theme-blog@1.5.22
     - gatsby-theme-notes@1.3.22
     - gatsby-theme-ui-preset@0.0.12
     - gatsby@2.21.22

commit f7dc43f
Author: Albert Lash <31164347+albertlincoln@users.noreply.github.com>
Date:   Mon May 11 11:52:59 2020 +0100

    fix(gatsby-cli): don't fail when using `--log-pages` and/or `--write-to-file` (#23951)

    * Adding new cli options for page optimization

    * prettier

    * make them hidden, add some description as well as comment about why they are hidden

    Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>

commit 88056f0
Author: Michal Piechowiak <misiek.piechowiak@gmail.com>
Date:   Mon May 11 01:17:47 2020 +0200

    fix(www): allow to tree shake lodash-es (#23967)

commit e267ca0
Author: Andrés Bedoya <Angelfire@users.noreply.github.com>
Date:   Sat May 9 15:51:42 2020 -0500

    Update deploying-to-zeit-now.md (#23946)
@KyleAMathews
Copy link
Contributor Author

Actually nerd snipped myself into trying it — thoughts?

Screen Shot 2020-05-11 at 8 32 39 PM

@jsjoeio
Copy link
Contributor

jsjoeio commented May 12, 2020

Besides that blue (which I'm guessing is your own settings), this looks way better 😄

@muescha
Copy link
Contributor

muescha commented May 12, 2020 •
edited
Loading

I would use an other background (white ?) for the snippet and maybe draw a box around it. and in box title the language. Maybe it is also ok just to make a different background in white and a language title in grey (and also a file name like js:title=gatsby-config.js)

Then it looks like in the docs as a code block. But I don't know how well this can be copied with a Unicode borderline

@KyleAMathews
Copy link
Contributor Author

Another go with some small dots

Screen Shot 2020-05-13 at 9 27 32 AM

@KyleAMathews KyleAMathews requested review from a team as code owners May 13, 2020 21:07
johno
johno approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@johno johno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐱

@KyleAMathews
Copy link
Contributor Author

Ok, going with this @pvdz suggested using just two dots to leave some space which looks nice

Screen Shot 2020-05-13 at 1 41 42 PM

@KyleAMathews KyleAMathews added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label May 13, 2020
@gatsbybot gatsbybot merged commit 6a322dc into master May 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the code-blog branch May 13, 2020 21:34
@KyleAMathews
Copy link
Contributor Author

Published in gatsby-cli@2.12.20

@KyleAMathews KyleAMathews mentioned this pull request May 14, 2020
Merged
@KyleAMathews
Copy link
Contributor Author

@pvdz pointed out the dots (while COOOL) would break copy / paste — sigh, terminals destroy all good UI ideas #24080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johno johno johno approved these changes

Assignees

@KyleAMathews KyleAMathews

Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KyleAMathews @jsjoeio @muescha @johno @gatsbybot