Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port ruby and python from ign-math6 #5

Merged
merged 4 commits into from
Mar 9, 2022
Merged

Port ruby and python from ign-math6 #5

merged 4 commits into from
Mar 9, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Mar 9, 2022 •
edited
Loading

@chapulina
Port ruby and python from ign-math6
bf82188 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from j-rivero March 9, 2022 00:59
@chapulina
fix symlink
1df2d68 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor Author

Test build: Build Status

@mjcarroll
Copy link 

�[0mTesting with python3.8:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'ignition_math7'
�[33mautopkgtest [01:57:32]: test autodep8-python3: -----------------------]
�[0m�[33mautopkgtest [01:57:32]: test autodep8-python3:  - - - - - - - - - - results - - - - - - - - - -
�[0mautodep8-python3     FAIL non-zero exit status 1

@chapulina
port more from ign-math6
fcb6fa6 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor Author

Ported more changes from ign-math6, new test build: Build Status

@mjcarroll
Copy link

Still grumpy, same issue.

@chapulina
Copy link
Contributor Author

The failing check has been recently added in

No ign-math6 releases have been made since, so the same problem may be happening there.

@j-rivero , any guidance here?

@chapulina chapulina mentioned this pull request Mar 9, 2022
Merged
@j-rivero
Copy link
Contributor

j-rivero commented Mar 9, 2022 •
edited
Loading

The failing check has been recently added in

You are almost there, just suffering a bite from the autopkgtest auto (double auto) generation of tests for python. That tool is generating broken tests for our python cases since it can not find customized tests (we have them, just missing symlinks). I did two things:

@chapulina
Copy link
Contributor Author

Thaaaaanks @j-rivero ! 🙏

@chapulina chapulina merged commit ef39536 into main Mar 9, 2022
@chapulina chapulina deleted the chapulina/scripting branch March 9, 2022 23:50
@scpeters
Copy link
Contributor

bionic debs are unstable:

I think the bionic/debian folder needs some symlinks to the new .install files

@chapulina
Copy link
Contributor Author

chapulina commented Mar 10, 2022 •
edited
Loading

@chapulina
Copy link
Contributor Author

@scpeters scpeters mentioned this pull request Mar 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero Awaiting requested review from j-rivero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chapulina @mjcarroll @j-rivero @scpeters