Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ign-physics1] Update BitBucket links #33

Merged
merged 6 commits into from
Apr 21, 2020

Conversation

chapulina
Copy link
Contributor

Signed-off-by: Louise Poubel louise@openrobotics.org

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some table of contents readme links are broken due to case-sensitivity

README.md Outdated
@@ -157,7 +157,7 @@ sudo update-alternatives --install \

# Usage

Please refer to the [examples directory](https://bitbucket.org/ignitionrobotics/ign-physics/raw/default/examples/?at=default).
Please refer to the [examples directory](https://github.com/ignitionrobotics/ign-physics/raw/master/examples/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this link is broken because the examples folder only exists on ign-physics2; we need to merge it forward to master

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the usage section for ign-physics1 because it doesn't have any examples. I think we should add it if we ever add examples to this version. This was probably here only because it's part of the template we used for all libs. Let me know what you think.

7573e5e

Signed-off-by: Steven Peters <scpeters@openrobotics.org>
Signed-off-by: Steven Peters <scpeters@openrobotics.org>
Signed-off-by: Steven Peters <scpeters@openrobotics.org>
@scpeters scpeters force-pushed the github_changelog_ign-physics1 branch from d007d0d to f5fee6e Compare April 21, 2020 05:08
@scpeters
Copy link
Member

some table of contents readme links are broken due to case-sensitivity

it wasn't actually case-sensitivity, but it's fixed in 154b18e

chapulina and others added 2 commits April 21, 2020 09:34
@chapulina chapulina merged commit 4496acd into ign-physics1 Apr 21, 2020
@chapulina chapulina deleted the github_changelog_ign-physics1 branch April 21, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants