4 ➡️ 5 #399
Merged
4 ➡️ 5 #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…363) * Moved ScreenToPlane and ScreenToScene from ign-gui to ign-rendering Signed-off-by: ahcorde <ahcorde@gmail.com> * added plane offset Signed-off-by: ahcorde <ahcorde@gmail.com> * Added new signature Signed-off-by: ahcorde <ahcorde@gmail.com> * Fix doxygen Signed-off-by: Steven Peters <scpeters@openrobotics.org> * Add const version of RayQueryResult bool operator Signed-off-by: Steven Peters <scpeters@openrobotics.org> * Improvements to Utils_TEST * Use tighter tolerances in expectations * Use IGN_PI/2 instead of 1.57 to tighten X tolerance * Clarify comments about max distance, which is only used when the ray does not intersect an object * Add expectations on RayQueryResult values * Add test of API without RayQueryResult Signed-off-by: Steven Peters <scpeters@openrobotics.org> * Test ScreenToPlane with non-zero offset Signed-off-by: Steven Peters <scpeters@openrobotics.org> Co-authored-by: Steven Peters <scpeters@openrobotics.org>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
…rendering3) (#376) * Set OGRE minimal version to 1.8. Warn on versions not supported. Flag USE_UNOFFICIAL_OGRE_VERSIONS to disable the warning for the experienced users. Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
* fix 0 hfov angle Signed-off-by: Ian Chen <ichen@osrfoundation.org> * use ignerr Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Codecov Report
@@ Coverage Diff @@
## ign-rendering5 #399 +/- ##
==================================================
+ Coverage 57.71% 57.77% +0.05%
==================================================
Files 161 161
Lines 15901 15947 +46
==================================================
+ Hits 9178 9213 +35
- Misses 6723 6734 +11
Continue to review full report at Codecov.
|
iche033
approved these changes
Sep 9, 2021
|
Ticketed #400 about the new warning on Ubuntu CI about not finding Ogre 1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port ign-rendering4 to ign-rendering5
Branch comparison: ign-rendering5...ign-rendering4
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)