Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Namespace Migration : gz-rendering #629

Merged
merged 28 commits into from
May 29, 2022
Merged

ign -> gz Namespace Migration : gz-rendering #629

merged 28 commits into from
May 29, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon requested a review from iche033 as a code owner May 18, 2022 05:54
@methylDragon methylDragon mentioned this pull request May 18, 2022
Closed
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 18, 2022
@chapulina chapulina added ign to gz Renaming Ignition to Gazebo. needs upstream release Blocked by a release of an upstream library labels May 18, 2022
chapulina
chapulina approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 🟢 CI, just some minor comments

Migration.md Outdated Show resolved Hide resolved
@methylDragon methylDragon force-pushed the namespace_migration branch 9 times, most recently from 41f234f to 81e427a Compare May 24, 2022 00:32
chapulina
chapulina suggested changes May 24, 2022
View reviewed changes
Changelog.md Outdated Show resolved Hide resolved
src/RenderEngineManager.cc Show resolved Hide resolved
@chapulina chapulina mentioned this pull request May 25, 2022
Closed
49 tasks
chapulina
chapulina suggested changes May 25, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the remaining env var migrations, LGTM

ogre/src/OgreMaterial.cc Show resolved Hide resolved
ogre/src/OgreRTShaderSystem.cc Show resolved Hide resolved
ogre/src/OgreRenderEngine.cc Show resolved Hide resolved
ogre2/src/Ogre2RenderEngine.cc Show resolved Hide resolved
ogre2/src/Ogre2RenderEngine.cc Show resolved Hide resolved
optix/src/OptixRenderEngine.cc Show resolved Hide resolved
src/base/BaseScene.cc Show resolved Hide resolved
@methylDragon methylDragon force-pushed the namespace_migration branch from 5104c79 to 1b70777 Compare May 25, 2022 23:00
chapulina
chapulina approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tick-tocks look good! LGTM with 🟢 CI!

examples/hello_world_plugin/README.md
@@ -1,7 +1,7 @@
# Engine plugin

This example shows how to create a plugin that integrates a rendering engine with
Ignition Rendering and how to load it with Ignition Gazebo.
Gazebo Rendering and how to load it with Gazebo.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Gazebo Rendering and how to load it with Gazebo.
Gazebo Rendering and how to load it with Gazebo Sim.

@methylDragon
Update header guards
892c93d 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate namespaces
45bcf8a 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Add migration line
49dd6ee 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Implement deprecation trick
f26ff80 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Add deprecation test
777b808 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Include config.hh
7c7bcd3 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Use pragma deprecation message instead
53075a0 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Ticktock config macros
7c453fc 
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon and others added 20 commits May 26, 2022 14:57
@methylDragon
Mention gz headers in migration and fix migration
0fa97fc 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate inline namespaces
f250071 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate includes to gz
6c5da24 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Update config.hh
8d05a87 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate Export.hh macros and deprecated test
56e69d2 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate github links
054f7d5 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate user-facing Ignition to Gazebo
029072a 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate gz-common logging calls
0ec2aa1 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Include config.hh in recursive directories and <lib>.hh
e55e7b6 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Include config.hh in .h and .hpp redirection headers
8866f47 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Gazebo Robotics -> Gazebo
009eea1 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
ignitionrobotics -> gazebosim
fb4dded 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Revert gazebosim/gz- to ignitionrobotics/ign- for osrf-migration
5fa2355 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Tick-tock GZ_RENDERING_PLUGIN_PATH
90c3fe5 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@chapulina @methylDragon
Fix variables and add migration note
3efddda 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@methylDragon
Tick-tock GZ_RENDERING_RESOURCE_PATH
4f47b17 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate Ignition's -> Gazebo's
502bb26 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Wording changes
9ac449d 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate igndbg -> gzdbg
a90546a 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Revert GZ_SIM_ env vars to IGNITION_GAZEBO_
a8c9b4c 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the namespace_migration branch from 70a9e97 to a8c9b4c Compare May 26, 2022 21:58
@codecov
Copy link

codecov bot commented May 29, 2022 •
edited
Loading

Codecov Report

Merging #629 (a8c9b4c) into main (1172916) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #629   +/-   ##
=======================================
  Coverage   80.00%   80.00%           
=======================================
  Files           1        1           
  Lines          15       15           
=======================================
  Hits           12       12           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1172916...a8c9b4c. Read the comment docs.

@methylDragon methylDragon merged commit 7f89b11 into main May 29, 2022
@methylDragon methylDragon deleted the namespace_migration branch May 29, 2022 01:02
@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina