Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable joint state publisher's topic #1076

Merged

Conversation

jasmeet0915
Copy link
Contributor

🎉 New feature

Closes #1057

Summary

Makes the topic for JointStatePublisher configurable

Expected behavior:

A user should be able to provide a topic for JointStatePublisher using <topic> in the sdf

configurable_joint_state_pub_topic

Test it

  • Choose an example world (I tested with diff_drive.sdf) and add JointStatePublisher to it while also specifying a topic with <topic> tags.
  • Then check if this topic gets listed with ign topic -l and you are able to echo it using ign topic -t $your_topic_name -e.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Oct 1, 2021
Signed-off-by: Jasmeet Singh <jasmeet0915@gmail.com>
…rror

Signed-off-by: Jasmeet Singh <jasmeet0915@gmail.com>
Signed-off-by: Jasmeet Singh <jasmeet0915@gmail.com>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating!

@chapulina chapulina merged commit adadda7 into gazebosim:ign-gazebo5 Nov 15, 2021
WilliamLewww pushed a commit to WilliamLewww/ign-gazebo that referenced this pull request Dec 7, 2021
Signed-off-by: Jasmeet Singh <jasmeet0915@gmail.com>
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

ijnek added a commit to ijnek/gz-sim that referenced this pull request Aug 28, 2022
Adding some API docs for changes from gazebosim#1076
ijnek added a commit to ijnek/gz-sim that referenced this pull request Aug 28, 2022
Adding some API docs for changes from gazebosim#1076

Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
ahcorde pushed a commit that referenced this pull request Aug 29, 2022
Adding some API docs for changes from #1076

Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
traversaro pushed a commit to traversaro/ign-gazebo that referenced this pull request Oct 19, 2022
Adding some API docs for changes from gazebosim#1076

Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Silvio <silvio@traversaro.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make joint state publisher's topic configurable
4 participants